fix: add case insensitive check for X-Goog-Content-SHA256 in SignatureInfo - #3337
Merged
BenWhitehead merged 1 commit intoOct 8, 2025
Merged
fix: add case insensitive check for X-Goog-Content-SHA256 in SignatureInfo#3337BenWhitehead merged 1 commit into
BenWhitehead merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
nidhiii-27
marked this pull request as ready for review
October 8, 2025 17:02
BenWhitehead
approved these changes
Oct 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes b/450079023
Based on this bug, the x-goog-content-sha256 header was not being correctly included in the V4 signature, leading to SignatureDoesNotMatch error. The issue was caused by a case-sensitive get() on the headers map, which failed to find the user-provided lowercase header.
Added a case insensitive check and a corresponding test to verify the fix