fix: add new system property (com.google.cloud.storage.grpc.bound_token) to allow disabling bound token use with grpc - #3365
Merged
BenWhitehead merged 4 commits intoOct 28, 2025
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
rockspore
force-pushed
the
bound-token-env-var
branch
from
3b84be0 to
330d939
Compare
October 27, 2025 16:48
rockspore
marked this pull request as ready for review
October 27, 2025 16:49
Copy link
Copy Markdown
Contributor
Author
|
@BenWhitehead Sorry for not doing this from the beginning. Would you mind taking a look? |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
@BenWhitehead I changed it to using system property. PTAL. Thanks! |
Sorry, something went wrong.
Comment thread
google-cloud-storage/src/main/java/com/google/cloud/storage/GrpcStorageOptions.java
Outdated
…pcStorageOptions.java Co-authored-by: BenWhitehead <BenWhitehead@users.noreply.github.com>
BenWhitehead
approved these changes
Oct 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Inspired by googleapis/java-bigtable#2695
The token issuing side is still behind so hopefully it's not too late to add this knob out of extra caution. Users will be able to use it to turn off this flow if anything goes wrong.