This repository was archived by the owner on Mar 3, 2026. It is now read-only.
feat(storage): add support for 'fields' query parameter to getFiles - #2521
Merged
ddelgrosso1 merged 13 commits intoSep 17, 2024
Merged
feat(storage): add support for 'fields' query parameter to getFiles#2521ddelgrosso1 merged 13 commits into
ddelgrosso1 merged 13 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
…elds'-to-getFiles feat(storage): add support for 'fields' query parameter to getFiles
…elds'-to-getFiles build: fix path-to-regexp to older version due to node 14 requirement
…elds'-to-getFiles Remove unnecessary sample code
thiyaguk09
commented
Sep 17, 2024
Comment thread
system-test/common.ts
Copy link
Copy Markdown
Contributor
Author
There was a problem hiding this comment.
We adjusted the test placement to address the previous failures.
Sorry, something went wrong.
ddelgrosso1
reviewed
Sep 17, 2024
Comment thread
package.json
| "proxyquire": "^2.1.3", | ||
| "sinon": "^18.0.0", | ||
| "nise": "6.0.0", | ||
| "path-to-regexp": "6.2.2", |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Let's just add a tacking issue to remove this once we upgrade to Node 18 minimum so we don't forget.
Sorry, something went wrong.
ddelgrosso1
approved these changes
Sep 17, 2024
ddelgrosso1
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Reviewers
1 more reviewer2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #2138