This repository was archived by the owner on Feb 23, 2026. It is now read-only.
fix: add operation name to x-goog-request-params - #133
Merged
busunkim96 merged 2 commits intoJan 25, 2021
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
This was referenced Jan 19, 2021
Closed
tseaver
approved these changes
Jan 20, 2021
turbaszek
approved these changes
Jan 25, 2021
software-dov
approved these changes
Jan 25, 2021
software-dov
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
LGTM, just some minor nitpicking.
Sorry, something went wrong.
Comment thread
google/api_core/operations_v1/operations_client.py
Outdated
Comment thread
google/api_core/operations_v1/operations_client.py
Outdated
Comment thread
google/api_core/operations_v1/operations_client.py
Outdated
Comment thread
google/api_core/operations_v1/operations_client.py
Outdated
gcf-merge-on-green Bot
pushed a commit
that referenced
this pull request
Feb 12, 2021
Pass the operation name in the `x-goog-request-params`header. Same as #133 for the async operations client.
This was referenced May 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Reviewers
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the routing header x-goog-request-params to operations client requests. Some APIs require that the header be passed on all requests.
Fixes googleapis/gapic-generator-python#732