This repository was archived by the owner on Feb 23, 2026. It is now read-only.
feat(api-core): add client_cert_source to ClientOptions - #17
Merged
arithmetic1728 merged 5 commits intoApr 14, 2020
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
busunkim96
reviewed
Mar 31, 2020
busunkim96
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
This looks good. Do you have the bandwith in the next few weeks to add this to the generators? We'll have to coordinate releasing api-core and updating the client library dependencies.
Sorry, something went wrong.
Comment thread
google/api_core/client_options.py
Outdated
Co-Authored-By: Bu Sun Kim <8822365+busunkim96@users.noreply.github.com>
Copy link
Copy Markdown
Contributor
Author
Yes, I am working on it right now. |
Sorry, something went wrong.
busunkim96
approved these changes
Apr 14, 2020
This was referenced May 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Reviewers
1 more reviewer3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #16