feat: Add support for rest/ token in x-goog-api-client header - #189
Conversation
Sorry, something went wrong.
This is required for (DI)REGAPIC clients, like GCE client.
|
The test are failing because of missing grpc dependency, which is listed as optional (thought it is not really optional). It has been like this before (should not be related to this specific change). |
Sorry, something went wrong.
| self.python_version = python_version | ||
| self.grpc_version = grpc_version | ||
| self.api_core_version = api_core_version | ||
| self.gapic_version = gapic_version | ||
| self.client_library_version = client_library_version | ||
| self.user_agent = user_agent | ||
| self.rest_version = rest_version |
There was a problem hiding this comment.
Should there be a check that either rest_version XOR grpc_version is set?
Sorry, something went wrong.
There was a problem hiding this comment.
Sounds reasonable to me, I was thinking about the same thing, but then decided that it would be safer to not add something like tha to a GA'ed library. If you feel strong about it, I can add it. Should I?
Sorry, something went wrong.
There was a problem hiding this comment.
I don't feel strongly about it, but it seems like a reasonable thing for someone looking at the fields to expect.
Sorry, something went wrong.
|
@vam-google It looks like lint is failing (everything else is passing) nox > flake8 google tests tests/unit/test_client_info.py:74:1: E302 expected 2 blank lines, found 1 nox > Session docfx was successful. nox > Ran multiple sessions: nox > * unit-2.7: success nox > * unit-3.6: success nox > * unit-3.7: success nox > * unit-3.8: success nox > * unit-3.9: success nox > * unit_grpc_gcp-2.7: success nox > * unit_grpc_gcp-3.6: success nox > * unit_grpc_gcp-3.7: success nox > * unit_grpc_gcp-3.8: success nox > * unit_grpc_gcp-3.9: success nox > * lint: failed nox > * lint_setup_py: success nox > * pytype: success nox > * cover: success nox > * docs: success nox > * docfx: success |
Sorry, something went wrong.
This is required for (DI)REGAPIC clients, like GCE client.