FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

feat: add iterator capability to paged iterators by plamut · Pull Request #200 · googleapis/python-api-core · GitHub

This repository was archived by the owner on Feb 23, 2026. It is now read-only.
/ python-api-core Public archive

feat: add iterator capability to paged iterators - #200

Merged
plamut merged 2 commits into
googleapis:masterfrom
plamut:iss-175
Jun 8, 2021
Merged

feat: add iterator capability to paged iterators#200
plamut merged 2 commits into
googleapis:masterfrom
plamut:iss-175

Conversation

plamut commented Jun 7, 2021

Copy link
Copy Markdown
Contributor

Closes #175.

This PR transforms *Iterator classes to actual iterators (before they were just iterables).

PR checklist:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

plamut added 2 commits June 7, 2021 13:16
The *Iterator classes are only _iterables_, and this commit also makes
them _iterators_, i.e. calling next(iterator) on them now works.
plamut requested review from a team and tswast June 7, 2021 12:49
google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label Jun 7, 2021
plamut merged commit 3487d68 into googleapis:master Jun 8, 2021
plamut deleted the iss-175 branch June 8, 2021 08:30
This was referenced May 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

paged iterators are not iterators

2 participants


Back | FazBrowse Home | New Git URL