This repository was archived by the owner on Feb 23, 2026. It is now read-only.
feat: AsyncIO Integration [Part 2] - #28
Merged
gcf-merge-on-green[bot] merged 4 commits intoJun 2, 2020
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
lidizheng
force-pushed
the
aio-part-2
branch
2 times, most recently
from
93a8cb8 to
41cf623
Compare
May 18, 2020 21:54
lidizheng
marked this pull request as ready for review
May 18, 2020 22:11
busunkim96
reviewed
May 27, 2020
Comment thread
docs/operation.rst
Outdated
Comment thread
google/api_core/operation_async.py
Outdated
Comment thread
google/api_core/operation_async.py
Outdated
Comment thread
google/api_core/future/async_future.py
lidizheng
commented
May 27, 2020
lidizheng
left a comment
Copy link
Copy Markdown
Contributor
Author
There was a problem hiding this comment.
@busunkim96 Thanks for reviewing! PTALA.
Sorry, something went wrong.
Comment thread
docs/operation.rst
Outdated
Comment thread
google/api_core/future/async_future.py
Comment thread
google/api_core/operation_async.py
Outdated
Comment thread
google/api_core/operation_async.py
Outdated
* Polling future * Page iterator * With unit tests & docs
Merged
busunkim96
approved these changes
May 27, 2020
Comment thread
docs/operation.rst
Outdated
Co-authored-by: Bu Sun Kim <8822365+busunkim96@users.noreply.github.com>
software-dov
approved these changes
Jun 2, 2020
software-dov
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Code looks good, tests look good, just one minor commentary nit.
Sorry, something went wrong.
Comment thread
google/api_core/page_iterator_async.py
Outdated
Copy link
Copy Markdown
Contributor
Author
|
Thanks for reviewing 👍 |
Sorry, something went wrong.
gcf-merge-on-green Bot
pushed a commit
that referenced
this pull request
Jun 4, 2020
🤖 I have created a release \*beep\* \*boop\* --- ## [1.18.0](https://www.github.com/googleapis/python-api-core/compare/v1.17.0...v1.18.0) (2020-06-04) ### Features * [CBT-6 helper] Exposing Retry._deadline as a property ([#20](https://www.github.com/googleapis/python-api-core/issues/20)) ([7be1e59](https://www.github.com/googleapis/python-api-core/commit/7be1e59e9d75c112f346d2b76dce3dd60e3584a1)) * add client_encryped_cert_source to ClientOptions ([#31](https://www.github.com/googleapis/python-api-core/issues/31)) ([e4eaec0](https://www.github.com/googleapis/python-api-core/commit/e4eaec0ff255114138d3715280f86d34d861a6fa)) * AsyncIO Integration [Part 2] ([#28](https://www.github.com/googleapis/python-api-core/issues/28)) ([dd9b2f3](https://www.github.com/googleapis/python-api-core/commit/dd9b2f38a70e85952cc05552ec8070cdf29ddbb4)), closes [#23](https://www.github.com/googleapis/python-api-core/issues/23) * First batch of AIO integration ([#26](https://www.github.com/googleapis/python-api-core/issues/26)) ([a82f289](https://www.github.com/googleapis/python-api-core/commit/a82f2892b8f219b82e120e6ed9f4070869c28be7)) * third batch of AsyncIO integration ([#29](https://www.github.com/googleapis/python-api-core/issues/29)) ([7d8d580](https://www.github.com/googleapis/python-api-core/commit/7d8d58075a92e93662747d36a2d55b5e9f0943e1)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please).
This was referenced May 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Reviewers
2 more reviewers4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Children PR of #26.
This PR includes AsyncIO version of:
The AsyncIO version of polling future still uses the same mechanism as the sync version. The AsyncIO polling future tries to update its own state whenever the application want to access information or perform actions.
For page iterator, it has similar interface design as sync version. But instead of fulfilling normal generator protocol, it is based on the async generator.
Related #23