FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

feat: add support for Python 3.11 by ziegenberg · Pull Request #466 · googleapis/python-api-core · GitHub

This repository was archived by the owner on Feb 23, 2026. It is now read-only.
/ python-api-core Public archive

feat: add support for Python 3.11 - #466

Merged
parthea merged 9 commits into
googleapis:mainfrom
ziegenberg:add-python-3-11-support
Nov 10, 2022
ConversationCommits (9)ChecksFiles changed
Merged

feat: add support for Python 3.11#466
parthea merged 9 commits into
googleapis:mainfrom
ziegenberg:add-python-3-11-support

Conversation

ziegenberg commented Nov 8, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #467 🦕

ziegenberg requested review from a team November 8, 2022 22:47
product-auto-label Bot added the size: s Pull request size is small. label Nov 8, 2022
ziegenberg force-pushed the add-python-3-11-support branch from acb6f92 to 6275bb5 Compare November 8, 2022 22:48

dandhlee commented Nov 9, 2022

Copy link
Copy Markdown
Contributor

Hi there, it doesn't seem like you're working with Google. Could you open a GitHub issue first?

ziegenberg commented Nov 9, 2022

Copy link
Copy Markdown
Contributor Author

Hi there, it doesn't seem like you're working with Google. Could you open a GitHub issue first?

That's right; I do work with Google. I will open an issue.

I followed #284 when creating this PR, which also did not have an accompanying issue.

ziegenberg force-pushed the add-python-3-11-support branch from 6275bb5 to 6556f1b Compare November 9, 2022 22:37
feat: add support for Python 3.11
34b87dc 
Signed-off-by: Daniel Ziegenberg <daniel@ziegenberg.at>
ziegenberg force-pushed the add-python-3-11-support branch from 6556f1b to 34b87dc Compare November 9, 2022 22:38

ziegenberg commented Nov 9, 2022

Copy link
Copy Markdown
Contributor Author

The python -m py.test call had to be changed to python -m pytest, otherwise it would always fail with:

Error while finding module specification for 'py.test' (ModuleNotFoundError: __path__ attribute not found on 'py' while trying to find 'py.test')

ziegenberg commented Nov 10, 2022

Copy link
Copy Markdown
Contributor Author

If it's okay with you, I would rebase my PR onto the current main. That should solve the Commit message did not follow Conventional Commits error.

parthea reviewed Nov 10, 2022
View reviewed changes

parthea left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I found that the minimum version of grpcio is 1.49.1 for python 3.11. I've updated the setup.py to reflect that.

parthea changed the title add support for Python 3.11 feat: add support for Python 3.11 Nov 10, 2022
parthea merged commit ff379e3 into googleapis:main Nov 10, 2022
release-please Bot mentioned this pull request Nov 10, 2022
Merged

parthea commented Nov 10, 2022

Copy link
Copy Markdown
Contributor

Thanks @ziegenberg!

ziegenberg deleted the add-python-3-11-support branch November 10, 2022 16:42
This was referenced May 30, 2025
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
parthea parthea approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

size: s Pull request size is small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

add support for Python 3.11

3 participants

Back | FazBrowse Home | New Git URL