FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix: update OperationsAsyncClient to use AsyncRetry by ohmayr · Pull Request #544 · googleapis/python-api-core · GitHub

This repository was archived by the owner on Feb 23, 2026. It is now read-only.
/ python-api-core Public archive

fix: update OperationsAsyncClient to use AsyncRetry - #544

Merged
parthea merged 1 commit into
mainfrom
update-async-client-to-use-async-retry
Nov 8, 2023
Merged

fix: update OperationsAsyncClient to use AsyncRetry#544
parthea merged 1 commit into
mainfrom
update-async-client-to-use-async-retry

Conversation

ohmayr commented Oct 30, 2023
edited
Loading

Copy link
Copy Markdown
Contributor

ohmayr requested review from a team October 30, 2023 02:01
product-auto-label Bot added the size: xs Pull request size is extra small. label Oct 30, 2023

vchudnov-g left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I suggest updating the the PR title to read "update OperationsAsyncClient to use AsyncRetry" (I mention this becase simply "client" makes me think of the generator, not core).

Otherwise LGTM. Thanks for dong this!

ohmayr changed the title fix: update async client to use async retry fix: update OperationsAsyncClient to use AsyncRetry Nov 3, 2023
parthea merged commit f21bb32 into main Nov 8, 2023
parthea deleted the update-async-client-to-use-async-retry branch November 8, 2023 17:00
This was referenced May 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

size: xs Pull request size is extra small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Async clients do not document and implement retries correctly (and hence retries don't work)

3 participants


Back | FazBrowse Home | New Git URL