FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix: replace deprecated `datetime.datetime.utcnow()` by DouglasBlackwood · Pull Request #552 · googleapis/python-api-core · GitHub

This repository was archived by the owner on Feb 23, 2026. It is now read-only.
/ python-api-core Public archive

fix: replace deprecated datetime.datetime.utcnow() - #552

Merged
parthea merged 2 commits into
googleapis:mainfrom
DouglasBlackwood:python3.12
Nov 17, 2023
ConversationCommits (2)ChecksFiles changed
Merged

fix: replace deprecated datetime.datetime.utcnow()#552
parthea merged 2 commits into
googleapis:mainfrom
DouglasBlackwood:python3.12

Conversation

DouglasBlackwood commented Nov 9, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

datetime.datetime.utcnow() is deprecated in Python 3.12.

Fixes #540

DouglasBlackwood requested review from a team November 9, 2023 22:06

google-cla Bot commented Nov 9, 2023

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

product-auto-label Bot added the size: s Pull request size is small. label Nov 9, 2023
vchudnov-g reviewed Nov 9, 2023
View reviewed changes

vchudnov-g left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This looks fine. Waiting for presubmits before formally approving.

DouglasBlackwood commented Nov 10, 2023

Copy link
Copy Markdown
Contributor Author

This looks fine. Waiting for presubmits before formally approving.

I'm sorry, I'm not familiar with this repository yet. What are presubmits? Do I have to do something?

parthea changed the title refactor: replace deprecated datetime.datetime.utcnow() fix: replace deprecated datetime.datetime.utcnow() Nov 17, 2023
parthea merged commit 448923a into googleapis:main Nov 17, 2023
release-please Bot mentioned this pull request Nov 17, 2023
Merged
parthea mentioned this pull request Dec 4, 2023
Closed
This was referenced May 30, 2025
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers
vchudnov-g vchudnov-g left review comments
parthea parthea approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

size: s Pull request size is small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

utcnow is deprecated in python3.12

3 participants

Back | FazBrowse Home | New Git URL