This repository was archived by the owner on Feb 23, 2026. It is now read-only.
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
…nary_async.AsyncRetry
ohmayr
approved these changes
Jan 30, 2024
daniel-sanche
approved these changes
Jan 30, 2024
Comment thread
google/api_core/retry_async/__init__.py
| "if_exception_type", | ||
| "if_transient_error", | ||
| "retry_target", | ||
| ) |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
This could also be potentially fixed with a file at google/api_core/retry_async.py, right?
Either way works for me, but it does seem like it could be confusing to have a retry_async folder, even though the actual async implementation is in /retry.
Using a retry_async.py file mirrors the old implementation, which feels slightly cleaner to me
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
There was a problem hiding this comment.
Fixed in 4f01471
Sorry, something went wrong.
vchudnov-g
approved these changes
Jan 30, 2024
Copy link
Copy Markdown
|
Nice! Super speedy one it seems :D. Thanks for handling it that quickly :D |
Sorry, something went wrong.
This was referenced May 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Reviewers
3 more reviewersAssignees
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #586 🦕