This repository was archived by the owner on Feb 23, 2026. It is now read-only.
feat: add google.api_core.version_header - #638
Merged
parthea merged 4 commits intoApr 29, 2024
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
parthea
force-pushed
the
add-api-version-header
branch
from
c4498a7 to
cbe0bb1
Compare
April 8, 2024 16:05
parthea
force-pushed
the
add-api-version-header
branch
4 times, most recently
from
578b720 to
ad08619
Compare
April 8, 2024 20:50
parthea
force-pushed
the
add-api-version-header
branch
from
93ef5e9 to
7b84e34
Compare
April 27, 2024 15:21
ohmayr
approved these changes
Apr 29, 2024
vchudnov-g
approved these changes
Apr 29, 2024
vchudnov-g
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Thanks for doing this!
Sorry, something went wrong.
Comment thread
google/api_core/version_header.py
Outdated
|
|
||
|
|
||
| def to_api_version_header(version_identifier): | ||
| """Returns the API Version header for the given `version_identifier`. |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
nit: it's not the header itself, but the data for the header....
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
There was a problem hiding this comment.
Fixed in 60b33e6
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
/cherry-pick v1 |
Sorry, something went wrong.
gcp-cherry-pick-bot Bot
pushed a commit
that referenced
this pull request
Apr 29, 2024
* feat: add google.api_core.gapic_v1.version_header * fix mypy * clarify comment
This was referenced May 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Reviewers
2 more reviewersAssignees
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Towards b/330968465