FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

feat: add support for python 3.13 by parthea · Pull Request #696 · googleapis/python-api-core · GitHub

This repository was archived by the owner on Feb 23, 2026. It is now read-only.
/ python-api-core Public archive

feat: add support for python 3.13 - #696

Merged
parthea merged 11 commits into
mainfrom
add-python-313
Oct 15, 2024
ConversationCommits (11)ChecksFiles changed
Merged

feat: add support for python 3.13#696
parthea merged 11 commits into
mainfrom
add-python-313

Conversation

parthea commented Sep 13, 2024

Copy link
Copy Markdown
Contributor

Fixes #695 🦕

parthea added the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 13, 2024
gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 13, 2024
product-auto-label Bot added the size: s Pull request size is small. label Sep 13, 2024
parthea added the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 13, 2024
gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 13, 2024

parthea commented Sep 13, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Blocked by grpc/grpc#34922

parthea added the status: blocked Resolving the issue is dependent on other work. label Sep 13, 2024
parthea self-assigned this Oct 9, 2024
parthea removed the status: blocked Resolving the issue is dependent on other work. label Oct 9, 2024
parthea marked this pull request as ready for review October 9, 2024 17:12
parthea requested review from a team October 9, 2024 17:12
parthea removed their assignment Oct 9, 2024
ohmayr approved these changes Oct 15, 2024
View reviewed changes
Comment thread noxfile.py
"google-auth",
"googleapis-common-protos",
"grpcio",
# Exclude grpcio!=1.67.0rc1 which does not support python 3.13

ohmayr Oct 15, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Do we need to disable the rc version? My assumption is that the latest stable version is installed by default.

parthea Oct 15, 2024

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Without this change, the pre-release test fails (See https://github.com/googleapis/python-api-core/actions/runs/11259852849/job/31309789274)

Do we need to disable the rc version? My assumption is that the latest stable version is installed by default.

We don't get the stable version in the prerelease_deps nox session. We get the latest pre-release which is https://pypi.org/project/grpcio/1.67.0rc1/. We're not disabling all rc versions, just 1.67.0rc1 which doesn't support python 3.13

Comment thread noxfile.py Outdated
Update comment
5fb2a14 
Co-authored-by: ohmayr <omairnaveed@ymail.com>
parthea merged commit 46b3d3a into main Oct 15, 2024
parthea deleted the add-python-313 branch October 15, 2024 16:49
release-please Bot mentioned this pull request Oct 9, 2024
Merged
parthea mentioned this pull request Oct 23, 2024
Closed
This was referenced May 30, 2025
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
ohmayr ohmayr approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

ohmayr

Labels

size: s Pull request size is small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add support for Python 3.13

2 participants

Back | FazBrowse Home | New Git URL