FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix: Improve `Any` decode error by MarkDaoust · Pull Request #712 · googleapis/python-api-core · GitHub

This repository was archived by the owner on Feb 23, 2026. It is now read-only.
/ python-api-core Public archive

fix: Improve Any decode error - #712

Merged
parthea merged 7 commits into
googleapis:mainfrom
MarkDaoust:any-error
Oct 22, 2024
ConversationCommits (7)ChecksFiles changed
Merged

fix: Improve Any decode error#712
parthea merged 7 commits into
googleapis:mainfrom
MarkDaoust:any-error

Conversation

MarkDaoust commented Oct 1, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Was (useless):

TypeError: Could not convert Any to TimeOfDay

Now:

TypeError: Could not convert `google.protobuf.any_pb2.Any` with underlying type `google.type.Date` to `google.type.TimeOfDay`

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

Fixes #711 🦕

Improve Any decoding-error.
9e01e2e 
Was:

TypeError: Could not convert Any to PredictLongRunningResponse

Now:

TypeError: Could not convert
   Any[google.ai.generativelanguage.v1main.PredictLongRunningResponse] to
       google.ai.generativelanguage.v1beta.PredictLongRunningResponse
MarkDaoust requested review from a team October 1, 2024 23:53
product-auto-label Bot added the size: xs Pull request size is extra small. label Oct 1, 2024

ohmayr commented Oct 4, 2024

Copy link
Copy Markdown
Contributor

@MarkDaoust Hmm looking at your comment above, is this right syntax Any[google.ai.generativelanguage.v1main.PredictLongRunningResponse] for Python?

ohmayr reviewed Oct 4, 2024
View reviewed changes
Comment thread google/api_core/protobuf_helpers.py Outdated
ohmayr changed the title Improve Any decoding-error. chore: Improve Any decode error Oct 4, 2024

conventional-commit-lint-gcf Bot commented Oct 4, 2024

Copy link
Copy Markdown

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

parthea self-assigned this Oct 9, 2024
parthea changed the title chore: Improve Any decode error fix: Improve Any decode error Oct 9, 2024
product-auto-label Bot added size: s Pull request size is small. and removed size: xs Pull request size is extra small. labels Oct 9, 2024
parthea assigned ohmayr and unassigned parthea and vchudnov-g Oct 9, 2024
parthea requested a review from ohmayr October 9, 2024 17:06
ohmayr approved these changes Oct 21, 2024
View reviewed changes
Comment thread tests/unit/test_protobuf_helpers.py Outdated
with pytest.raises(
TypeError,
match=re.escape(
"Could not convert `google.protobuf.any_pb2.Any` with underlying type `google.type.Date` to `google.type.TimeOfDay`"

ohmayr Oct 21, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Am I reading this correct or should it instead be the following? (My assumption is that the underlying type should be Any).

Suggested change
"Could not convert `google.protobuf.any_pb2.Any` with underlying type `google.type.Date` to `google.type.TimeOfDay`"
"Could not convert `google.type.Date` with underlying type `google.protobuf.any_pb2.Any` to `google.type.TimeOfDay`"

parthea Oct 22, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Fixed in dc33849

parthea enabled auto-merge (squash) October 22, 2024 14:23
parthea merged commit 0d5ed37 into googleapis:main Oct 22, 2024
release-please Bot mentioned this pull request Oct 22, 2024
Merged
parthea mentioned this pull request Oct 23, 2024
Closed
This was referenced May 30, 2025
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers
parthea parthea left review comments
ohmayr ohmayr approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

ohmayr

Labels

size: s Pull request size is small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

from_any_pb gives a useless error message when the type names don't match.

4 participants

Back | FazBrowse Home | New Git URL