FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix: memory leak in bidi classes by daniel-sanche · Pull Request #770 · googleapis/python-api-core · GitHub

This repository was archived by the owner on Feb 23, 2026. It is now read-only.
/ python-api-core Public archive

fix: memory leak in bidi classes - #770

Merged
parthea merged 3 commits into
mainfrom
fix_mem_leak
Jan 22, 2025
ConversationCommits (3)ChecksFiles changed
Merged

fix: memory leak in bidi classes#770
parthea merged 3 commits into
mainfrom
fix_mem_leak

Conversation

daniel-sanche commented Dec 16, 2024

Copy link
Copy Markdown
Contributor

Fixes #769

daniel-sanche requested review from a team December 16, 2024 22:23
product-auto-label Bot added the size: s Pull request size is small. label Dec 16, 2024
daniel-sanche mentioned this pull request Dec 16, 2024
Closed
daniel-sanche commented Dec 16, 2024
View reviewed changes
Comment thread google/api_core/bidi.py
_LOGGER.warning("Background thread did not exit.")

self._thread = None
self._on_response = None

daniel-sanche Dec 16, 2024

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This assumes you can't restart an instance after it has been stopped. The test cases and docstrings point to that being the case, but it's not completely clear

parthea Jan 22, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I think this is a reasonable assumption given that resources should be cleaned up when close is called. Regardless, we'll publish a pre-release to get feedback on this change before publishing a normal release.

parthea approved these changes Jan 22, 2025
View reviewed changes
Comment thread google/api_core/bidi.py
_LOGGER.warning("Background thread did not exit.")

self._thread = None
self._on_response = None

parthea Jan 22, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I think this is a reasonable assumption given that resources should be cleaned up when close is called. Regardless, we'll publish a pre-release to get feedback on this change before publishing a normal release.

parthea merged commit c1b8afa into main Jan 22, 2025
parthea deleted the fix_mem_leak branch January 22, 2025 21:46

parthea commented Jan 22, 2025

Copy link
Copy Markdown
Contributor

Thanks @daniel-sanche !

release-please Bot mentioned this pull request Jan 22, 2025
Merged
parthea mentioned this pull request Jan 23, 2025
Closed
daniel-sanche mentioned this pull request Feb 1, 2025
Closed
daniel-sanche mentioned this pull request Apr 4, 2025
Merged
This was referenced May 30, 2025
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
parthea parthea approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

parthea

Labels

size: s Pull request size is small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Memory leak in bidi resources

2 participants

Back | FazBrowse Home | New Git URL