This repository was archived by the owner on Mar 2, 2026. It is now read-only.
Commit e6fd577
authored
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -430,8 +430,12 @@ def test_aggregation_query_prep_stream_with_read_time(): | |||
| 430 | 430 | assert kwargs == {"retry": None} | |
| 431 | 431 | ||
| 432 | 432 | ||
| 433 | - @pytest.mark.parametrize("timezone", [None, timezone.utc, timezone(timedelta(hours=5))]) | ||
| 434 | - def test_aggregation_query_get_stream_iterator_read_time_different_timezones(timezone): | ||
| 433 | + @pytest.mark.parametrize( | ||
| 434 | + "custom_timezone", [None, timezone.utc, timezone(timedelta(hours=5))] | ||
| 435 | + ) | ||
| 436 | + def test_aggregation_query_get_stream_iterator_read_time_different_timezones( | ||
| 437 | + custom_timezone, | ||
| 438 | + ): | ||
| 435 | 439 | client = make_client() | |
| 436 | 440 | parent = client.collection("dee") | |
| 437 | 441 | query = make_query(parent) | |
@@ -441,10 +445,8 @@ def test_aggregation_query_get_stream_iterator_read_time_different_timezones(tim | |||
| 441 | 445 | aggregation_query.sum("someref", alias="sumall") | |
| 442 | 446 | aggregation_query.avg("anotherref", alias="avgall") | |
| 443 | 447 | ||
| 444 | - # 1800 seconds after epoch | ||
| 445 | - read_time = datetime(1970, 1, 1, 0, 30) | ||
| 446 | - if timezone is not None: | ||
| 447 | - read_time = read_time.astimezone(timezone) | ||
| 448 | + # 1800 seconds after epoch in user-specified timezone | ||
| 449 | + read_time = datetime.fromtimestamp(1800, tz=custom_timezone) | ||
| 448 | 450 | ||
| 449 | 451 | # The internal firestore API needs to be initialized before it gets mocked. | |
| 450 | 452 | client._firestore_api | |
0 commit comments