Fix update test to use new endpoint [(#1925)](https://github.com/Goog… · googleapis/python-pubsub@f67c22a · GitHub

This repository was archived by the owner on Mar 9, 2026. It is now read-only.

googleapis / python-pubsub Public archive

• Notifications You must be signed in to change notification settings
• Fork 215
• Star 429

• Code
• Issues
• Pull requests
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit f67c22a

Browse filesBrowse the repository at this point in the historyBrowse files

engelke

authored and

plamut

committed

Fix update test to use new endpoint [(#1925)](GoogleCloudPlatform/python-docs-samples#1925)

* Fix update test to use new endpoint * Handle subscription already exists Previous deletions don't always succeed * Use a new endpoint for update

1 parent 59c959c commit f67c22a
Copy full SHA for f67c22a

1 file changed

+8-6Lines changed: 8 additions & 6 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• samples/snippets
  • subscriber_test.py

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎samples/snippets/subscriber_test.py‎

Copy file name to clipboardExpand all lines: samples/snippets/subscriber_test.py

+8-6Lines changed: 8 additions & 6 deletions

Original file line number	Diff line number	Diff line change
@@ -17,6 +17,7 @@
17	17
18	18	from gcp_devrel.testing import eventually_consistent
19	19	from google.cloud import pubsub_v1
	20	+ import google.api_core.exceptions
20	21	import mock
21	22	import pytest
22	23
@@ -28,6 +29,7 @@
28	29	SUBSCRIPTION_SYNC1 = 'subscription-test-subscription-sync1'
29	30	SUBSCRIPTION_SYNC2 = 'subscription-test-subscription-sync2'
30	31	ENDPOINT = 'https://{}.appspot.com/push'.format(PROJECT)
	32	+ NEW_ENDPOINT = 'https://{}.appspot.com/push2'.format(PROJECT)
31	33
32	34
33	35	@pytest.fixture(scope='module')
@@ -64,7 +66,10 @@ def subscription(subscriber_client, topic):
64	66	except Exception:
65	67	pass
66	68
67		- subscriber_client.create_subscription(subscription_path, topic=topic)
	69	+ try:
	70	+ subscriber_client.create_subscription(subscription_path, topic=topic)
	71	+ except google.api_core.exceptions.AlreadyExists:
	72	+ pass
68	73
69	74	yield subscription_path
70	75
@@ -155,13 +160,10 @@ def _():
155	160
156	161
157	162	def test_update(subscriber_client, subscription, capsys):
158		- ACK_DEADLINE_SECONDS = 100
159		-
160		- subscriber.update_subscription(PROJECT, SUBSCRIPTION, ACK_DEADLINE_SECONDS)
	163	+ subscriber.update_subscription(PROJECT, SUBSCRIPTION, NEW_ENDPOINT)
161	164
162	165	out, _ = capsys.readouterr()
163		- assert subscription in out
164		- assert '100' in out
	166	+ assert 'Subscription updated' in out
165	167
166	168
167	169	def _publish_messages(publisher_client, topic):

0 commit comments

Comments

0 (0)