This repository was archived by the owner on Mar 9, 2026. It is now read-only.
fix: Update stream_ack_deadline with ack_deadline - #763
Merged
acocuzzo merged 4 commits intoAug 11, 2022
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
maheshgattani
approved these changes
Aug 11, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Reviewers
1 more reviewerAssignees
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates stream_ack_deadline along with ack_deadline to prevent a lower stream_ack_deadline being sent on the heartbeat if the ack_deadline has been updated.
Correctly sets initial request ack_deadline_seconds to stream_ack_deadline instead of ack_deadline
Fixes #758 🦕