fix: support merging for NUMERIC values (#434) · googleapis/python-spanner@06b4215 · GitHub

This repository was archived by the owner on Jun 8, 2026. It is now read-only.

googleapis / python-spanner Public archive

• Notifications You must be signed in to change notification settings
• Fork 103
• Star 155

• Code
• Issues
• Pull requests
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 06b4215

Browse filesBrowse the repository at this point in the historyBrowse files

larkee

authored

fix: support merging for NUMERIC values (#434)

Fixes #433

1 parent 93c09ab commit 06b4215
Copy full SHA for 06b4215

2 files changed

+14Lines changed: 14 additions & 0 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• google/cloud/spanner_v1
  • streamed.py
• tests/unit
  • test_streamed.py

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎google/cloud/spanner_v1/streamed.py‎

Copy file name to clipboardExpand all lines: google/cloud/spanner_v1/streamed.py

+1Lines changed: 1 addition & 0 deletions

Original file line number	Diff line number	Diff line change
@@ -315,6 +315,7 @@ def _merge_struct(lhs, rhs, type_):
315	315	TypeCode.STRING: _merge_string,
316	316	TypeCode.STRUCT: _merge_struct,
317	317	TypeCode.TIMESTAMP: _merge_string,
	318	+ TypeCode.NUMERIC: _merge_string,
318	319	}
319	320
320	321

Collapse file

‎tests/unit/test_streamed.py‎

Copy file name to clipboardExpand all lines: tests/unit/test_streamed.py

+13Lines changed: 13 additions & 0 deletions

Original file line number	Diff line number	Diff line change
@@ -164,6 +164,19 @@ def test__merge_chunk_bool(self):
164	164	with self.assertRaises(Unmergeable):
165	165	streamed._merge_chunk(chunk)
166	166
	167	+ def test__merge_chunk_numeric(self):
	168	+ from google.cloud.spanner_v1 import TypeCode
	169	+
	170	+ iterator = _MockCancellableIterator()
	171	+ streamed = self._make_one(iterator)
	172	+ FIELDS = [self._make_scalar_field("total", TypeCode.NUMERIC)]
	173	+ streamed._metadata = self._make_result_set_metadata(FIELDS)
	174	+ streamed._pending_chunk = self._make_value(u"1234.")
	175	+ chunk = self._make_value(u"5678")
	176	+
	177	+ merged = streamed._merge_chunk(chunk)
	178	+ self.assertEqual(merged.string_value, u"1234.5678")
	179	+
167	180	def test__merge_chunk_int64(self):
168	181	from google.cloud.spanner_v1 import TypeCode
169	182

0 commit comments

Comments

0 (0)