tests/unit/*tracing: pass current span into assertions · googleapis/python-spanner@ab23f09 · GitHub

This repository was archived by the owner on Jun 8, 2026. It is now read-only.

googleapis / python-spanner Public archive

• Notifications You must be signed in to change notification settings
• Fork 103
• Star 155

• Code
• Issues
• Pull requests
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit ab23f09

Browse filesBrowse the repository at this point in the historyBrowse files

odeke-em

committed

tests/unit/*tracing: pass current span into assertions

This allows us to avoid the flakes with OpenTelemetry's inMemorySpanExporter that might not have received the exported spans yet.

1 parent f59084c commit ab23f09
Copy full SHA for ab23f09

2 files changed

+7-4Lines changed: 7 additions & 4 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• tests
  • _helpers.py
  • unit
    • test_session.py

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎tests/_helpers.py‎

Copy file name to clipboardExpand all lines: tests/_helpers.py

+4-1Lines changed: 4 additions & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -101,4 +101,7 @@ def assertSpanEvents(self, name, wantEventNames=[], span=None):
101	101	span = span_list[0]
102	102
103	103	self.assertEqual(span.name, name)
104		- self.assertEqual(len(span.events), len(wantEventNames))
	104	+ actualEventNames = []
	105	+ for event in span.events:
	106	+ actualEventNames.append(event.name)
	107	+ self.assertEqual(actualEventNames, wantEventNames)

Collapse file

‎tests/unit/test_session.py‎

Copy file name to clipboardExpand all lines: tests/unit/test_session.py

+3-3Lines changed: 3 additions & 3 deletions

Original file line number	Diff line number	Diff line change
@@ -189,7 +189,7 @@ def test_create_session_span_annotations(self):
189	189	database.spanner_api = gax_api
190	190	session = self._make_one(database, database_role=self.DATABASE_ROLE)
191	191
192		- with trace_call("TestSessionSpan", session):
	192	+ with trace_call("TestSessionSpan", session) as span:
193	193	session.create()
194	194
195	195	self.assertEqual(session.session_id, self.SESSION_ID)
@@ -209,8 +209,8 @@ def test_create_session_span_annotations(self):
209	209	],
210	210	)
211	211
212		- wantEventNames = ["Acquiring session", "Creating Session", "Using Session"]
213		- self.assertSpanEvents("CloudSpanner.CreateSession", wantEventNames)
	212	+ wantEventNames = ["Creating Session", "Using Session"]
	213	+ self.assertSpanEvents("TestSessionSpan", wantEventNames, span)
214	214
215	215	def test_create_wo_database_role(self):
216	216	from google.cloud.spanner_v1 import CreateSessionRequest

0 commit comments

Comments

0 (0)