FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

feat: Add support for max commit delay by nginsberg-google · Pull Request #1050 · googleapis/python-spanner · GitHub

This repository was archived by the owner on Jun 8, 2026. It is now read-only.
/ python-spanner Public archive

feat: Add support for max commit delay - #1050

Merged
harshachinta merged 32 commits into
googleapis:mainfrom
nginsberg-google:max-commit-delay2
Feb 5, 2024
ConversationCommits (32)ChecksFiles changed
Merged

feat: Add support for max commit delay#1050
harshachinta merged 32 commits into
googleapis:mainfrom
nginsberg-google:max-commit-delay2

Conversation

nginsberg-google commented Dec 5, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

This feature adds support for max_commit_delays on commits to spanner.

nginsberg-google requested review from a team December 5, 2023 23:55
product-auto-label Bot added size: m Pull request size is medium. api: spanner Issues related to the googleapis/python-spanner API. labels Dec 5, 2023
harshachinta reviewed Jan 7, 2024
View reviewed changes
Comment thread google/cloud/spanner_v1/batch.py Outdated
harshachinta reviewed Jan 7, 2024
View reviewed changes
Comment thread google/cloud/spanner_v1/batch.py Outdated
harshachinta added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 25, 2024
harshachinta reviewed Jan 28, 2024
View reviewed changes
Comment thread google/cloud/spanner_v1/database.py Outdated
harshachinta reviewed Jan 28, 2024
View reviewed changes

harshachinta left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM. Just one minor comment on adding range in the docs comment.

harshachinta added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 28, 2024
yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 28, 2024
harshachinta added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 29, 2024
yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 29, 2024

nginsberg-google commented Jan 30, 2024

Copy link
Copy Markdown
Contributor Author

I think this should be ready to merge. What are the next steps here? Thanks!

harshachinta added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 30, 2024
yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 30, 2024
harshachinta added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 30, 2024
yoshi-kokoro removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Jan 30, 2024
harshachinta added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jan 30, 2024
harshachinta added kokoro:force-run Add this label to force Kokoro to re-run the tests. and removed do not merge Indicates a pull request not ready for merge, due to either quality or timing. labels Feb 2, 2024
yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 2, 2024
harshachinta added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 2, 2024
yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 2, 2024
harshachinta merged commit d5acc26 into googleapis:main Feb 5, 2024
release-please Bot mentioned this pull request Feb 5, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
harshachinta harshachinta approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: spanner Issues related to the googleapis/python-spanner API. size: m Pull request size is medium.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL