This repository was archived by the owner on Jun 8, 2026. It is now read-only.
fix(tracing): only set span.status=OK if UNSET - #1248
Merged
harshachinta merged 4 commits intoDec 6, 2024
Merged
harshachinta merged 4 commits into
harshachinta merged 4 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
harshachinta
reviewed
Dec 4, 2024
Comment thread
google/cloud/spanner_v1/_opentelemetry_tracing.py
harshachinta
reviewed
Dec 4, 2024
Comment thread
tests/unit/test__opentelemetry_tracing.py
harshachinta
reviewed
Dec 4, 2024
Comment thread
tests/unit/test__opentelemetry_tracing.py
harshachinta
reviewed
Dec 4, 2024
Comment thread
google/cloud/spanner_v1/_opentelemetry_tracing.py
Outdated
odeke-em
force-pushed
the
trace-fix-trace_call-unconditionally-setting-span_status_OK
branch
from
d1018ac to
f1d41ee
Compare
December 4, 2024 11:39
harshachinta
approved these changes
Dec 4, 2024
In modernized OpenTelemetry-Python, if the SpanStatus was not already set to OK, it can be changed and the code for trace_call was accidentally unconditionally setting the status to OK if there was no exception. This change fixes that and adds tests to lock this behavior in. Fixes googleapis#1246
odeke-em
force-pushed
the
trace-fix-trace_call-unconditionally-setting-span_status_OK
branch
from
f1d41ee to
981fab5
Compare
December 5, 2024 06:35
harshachinta
enabled auto-merge (squash)
December 6, 2024 06:09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Reviewers
1 more reviewerAssignees
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In modernized OpenTelemetry-Python, if the SpanStatus was not already set to OK, it can be changed and
the code for trace_call was accidentally unconditionally setting the status to OK if there was no exception. This change fixes that and adds tests to lock this behavior in.
Fixes #1246