This repository was archived by the owner on Jun 8, 2026. It is now read-only.
feat(x-goog-spanner-request-id): introduce AtomicCounter - #1275
Merged
olavloite merged 4 commits intoDec 19, 2024
Merged
olavloite merged 4 commits into
olavloite merged 4 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
This change introduces AtomicCounter, a concurrency/thread-safe counter do deal with the multi-threaded nature of variables. It permits operations: * atomic_counter += 1 * value = atomic_counter + 1 * atomic_counter.value that'll be paramount to bringing in the logic for x-goog-spanner-request-id in much reduced changelists. Updates #1261 Carved out from PR googleapis#1264
olavloite
approved these changes
Dec 19, 2024
Comment thread
tests/unit/test_atomic_counter.py
Outdated
Comment thread
tests/unit/test_atomic_counter.py
Comment thread
google/cloud/spanner_v1/request_id_header.py
Copy link
Copy Markdown
Contributor
Author
|
Thank you for the reivew and approval @olavloite! I've updated the tests too. Kindly please help me run the bots too. |
Sorry, something went wrong.
olavloite
enabled auto-merge (squash)
December 19, 2024 19:18
aakashanandg
pushed a commit
to aakashanandg/python-spanner
that referenced
this pull request
Jan 2, 2025
…1275) * feat(x-goog-spanner-request-id): introduce AtomicCounter This change introduces AtomicCounter, a concurrency/thread-safe counter do deal with the multi-threaded nature of variables. It permits operations: * atomic_counter += 1 * value = atomic_counter + 1 * atomic_counter.value that'll be paramount to bringing in the logic for x-goog-spanner-request-id in much reduced changelists. Updates #1261 Carved out from PR googleapis#1264 * Tests for with_request_id * chore: remove sleep * chore: remove unused import --------- Co-authored-by: Knut Olav Løite <koloite@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Reviewers
1 more reviewerAssignees
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change introduces AtomicCounter, a concurrency/thread-safe counter do deal with the multi-threaded nature of variables. It permits operations:
that'll be paramount to bringing in the logic for
x-goog-spanner-request-id in much reduced changelists.
Updates googleapis/google-cloud-python#15905
Carved out from PR #1264