This repository was archived by the owner on Jun 8, 2026. It is now read-only.
feat: add support for spanner copy backup feature - #600
Merged
asthamohta merged 13 commits intoMar 25, 2022
Merged
asthamohta merged 13 commits into
asthamohta merged 13 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
larkee
reviewed
Nov 17, 2021
Comment thread
google/cloud/spanner_v1/backup.py
Outdated
Copy link
Copy Markdown
Contributor
|
Also, PR titles should follow the Commit Message Guidelines. The rest LGTM 👍 |
Sorry, something went wrong.
larkee
approved these changes
Nov 29, 2021
Comment thread
tests/system/test_backup_api.py
Outdated
| op.result() # blocks indefinitely | ||
|
|
||
|
|
||
| def test_copy_backup_create_w_invalid_expire_time( |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
nit: prefer to include this case in test_copy_backup_workflow in order to reuse the created source backup and minimize the number of created backups.
Sorry, something went wrong.
asthamohta
force-pushed
the
spanner-copy-backup
branch
2 times, most recently
from
6fd58af to
8c1c404
Compare
December 24, 2021 13:35
asthamohta
force-pushed
the
spanner-copy-backup
branch
from
8c1c404 to
cf138b7
Compare
December 24, 2021 13:36
larkee
approved these changes
Dec 30, 2021
Copy link
Copy Markdown
|
Here is the summary of changes. You are about to add 1 region tag.
This comment is generated by snippet-bot.
|
Sorry, something went wrong.
* Synchronize new proto/yaml changes. PiperOrigin-RevId: 436114471 Source-Link: googleapis/googleapis@6379d5f Source-Link: https://github.com/googleapis/googleapis-gen/commit/a59984b4cb711eeb186bca4f5b35adbfe60825df Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYTU5OTg0YjRjYjcxMWVlYjE4NmJjYTRmNWIzNWFkYmZlNjA4MjVkZiJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
asthamohta
force-pushed
the
spanner-copy-backup
branch
from
64ece0b to
caf4b0b
Compare
March 23, 2022 12:01
asthamohta
force-pushed
the
spanner-copy-backup
branch
from
3568e9d to
22bed64
Compare
March 24, 2022 05:17
asthamohta
force-pushed
the
spanner-copy-backup
branch
6 times, most recently
from
d8aa15d to
eacd97c
Compare
March 25, 2022 05:25
asthamohta
force-pushed
the
spanner-copy-backup
branch
from
eacd97c to
ac4e13b
Compare
March 25, 2022 07:26
vi3k6i5
pushed a commit
to vi3k6i5/python-spanner
that referenced
this pull request
Mar 29, 2022
* changes for copy backup feature * changes to test case * changes to documenttation * feat: changes as per review, adding shared_backup * changes for cross region backup * samples: changes to list backup operations * chore(deps): update all dependencies (googleapis#689) * chore(deps): update dependency pytest to v7.1.1 (googleapis#690) * feat: add support for Cross region backup proto changes (googleapis#691) * Synchronize new proto/yaml changes. PiperOrigin-RevId: 436114471 Source-Link: googleapis/googleapis@6379d5f Source-Link: googleapis/googleapis-gen@a59984b Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYTU5OTg0YjRjYjcxMWVlYjE4NmJjYTRmNWIzNWFkYmZlNjA4MjVkZiJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> * feat: adding samples * linting Co-authored-by: WhiteSource Renovate <bot@renovateapp.com> Co-authored-by: gcf-owl-bot[bot] <78513119+gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding support for Cloud Spanner Cross-Region Backups. This feature allows customers to copy the backup to instances in different regions after creating a backup of the database. The following PR adds the following functionalities: