FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix(deps): require google-api-core >= 1.31.5, >= 2.3.2 on v2 release by busunkim96 · Pull Request #688 · googleapis/python-spanner · GitHub

This repository was archived by the owner on Jun 8, 2026. It is now read-only.
/ python-spanner Public archive

fix(deps): require google-api-core >= 1.31.5, >= 2.3.2 on v2 release - #688

Merged
busunkim96 merged 6 commits into
v2from
v2-api-core-pin
Apr 6, 2022
Merged

busunkim96 merged 6 commits into
v2from
v2-api-core-pin

Conversation

Copy link
Copy Markdown
Contributor

Allow google-api-core<3.0.0dev on previous release of library. Note that this PR is to a new protected branch v2, not main.

This will be followed by a release PR and is a step towards removing googleapis/google-cloud-python#10566

busunkim96 requested review from a team and parthea March 11, 2022 01:52
product-auto-label Bot added the api: spanner Issues related to the googleapis/python-spanner API. label Mar 11, 2022
busunkim96 changed the title chore(deps): allow google-api-core v2 on v2 release chore(deps): allow google-api-core v2, google-cloud-core on v2 release Mar 11, 2022
busunkim96 changed the title chore(deps): allow google-api-core v2, google-cloud-core on v2 release chore(deps): allow google-api-core, google-cloud-core v2 on v2 release Mar 11, 2022
parthea changed the title chore(deps): allow google-api-core, google-cloud-core v2 on v2 release fix(deps): require google-api-core >= 1.31.5, >= 2.3.2 on v2 release Mar 14, 2022

Copy link
Copy Markdown
Contributor Author

It looks like CODEOWNERS enforcement comes from the branch the changes are being made to. On main, the latest https://github.com/googleapis/python-spanner/blob/main/.github/CODEOWNERS allows approval from yoshi-python or api-spanner. Merging since I've obtained approval from @parthea in yoshi-python.

busunkim96 merged commit ad8ba58 into v2 Apr 6, 2022
busunkim96 deleted the v2-api-core-pin branch April 6, 2022 21:41
busunkim96 added the release-please:force-run To run release-please label Apr 7, 2022
release-please Bot removed the release-please:force-run To run release-please label Apr 7, 2022
release-please Bot mentioned this pull request Apr 7, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: spanner Issues related to the googleapis/python-spanner API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants


Back | FazBrowse Home | New Git URL