This repository was archived by the owner on May 14, 2026. It is now read-only.
fix: delete stale instance with delay of 5 seconds - #194
Merged
vi3k6i5 merged 2 commits intoJan 27, 2022
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
IlyaFaer
approved these changes
Jan 18, 2022
Copy link
Copy Markdown
There was a problem hiding this comment.
LGTM
The error failing in your tests:
DeprecationWarning: '@pytest.fixture' is applied to <fixture Class._inject_setup_class_fixture.<locals>.xunit_setup_class_fixture, file=/home/runner/work/python-spanner-sqlalchemy/python-spanner-sqlalchemy/.nox/compliance_test/lib/python3.8/site-packages/_pytest/python.py, line=802> in 'legacy' mode, please replace it with '@pytest_asyncio.fixture' as a preparation for switching to 'strict' mode (or use 'auto' mode to seamlessly handle all these fixtures as asyncio-driven).It's gonna be fixed by this PR: #191, I just need to process a couple of more errors there.
Sorry, something went wrong.
vi3k6i5
force-pushed
the
ft-instance-cleanup
branch
from
cf3920a to
7a3c055
Compare
January 18, 2022 07:51
Copy link
Copy Markdown
|
A transient deadline error happened in snippets session. Rerunning the checks. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding sleep of 5 seconds after instance delete call, this will ensure that if multiple instances need to be cleaned up then there is sufficient gap between successive api calls.