fix: raise ValueError if api_endpoint is unset when using AnonymousCr… · googleapis/python-storage@17828ea · GitHub

This repository was archived by the owner on Mar 31, 2026. It is now read-only.

googleapis / python-storage Public archive

• Notifications You must be signed in to change notification settings
• Fork 173
• Star 503

• Code
• Issues
• Pull requests
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 17828ea

Browse filesBrowse the repository at this point in the historyBrowse files

chandra-siri

authored

fix: raise ValueError if api_endpoint is unset when using AnonymousCredentials in AsyncGrpcClient. (#1778)

Added validation to ensure `api_endpoint` is provided when using `AnonymousCredentials` in `AsyncGrpcClient`.

1 parent 8b7fbde commit 17828ea
Copy full SHA for 17828ea

2 files changed

+21Lines changed: 21 additions & 0 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• google/cloud/storage/asyncio
  • async_grpc_client.py
• tests/unit/asyncio
  • test_async_grpc_client.py

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎google/cloud/storage/asyncio/async_grpc_client.py‎

Copy file name to clipboardExpand all lines: google/cloud/storage/asyncio/async_grpc_client.py

+4Lines changed: 4 additions & 0 deletions

Original file line number	Diff line number	Diff line change
@@ -55,6 +55,10 @@ def __init__(
55	55	attempt_direct_path=True,
56	56	):
57	57	if isinstance(credentials, auth_credentials.AnonymousCredentials):
	58	+ if client_options is None or client_options.api_endpoint is None:
	59	+ raise ValueError(
	60	+ "Either client_options or `client_option.api_endpoint` is None. Please provide api_endpoint when `AnonymousCredentials` is used "
	61	+ )
58	62	self._grpc_client = self._create_anonymous_client(
59	63	client_options, credentials
60	64	)

Collapse file

‎tests/unit/asyncio/test_async_grpc_client.py‎

Copy file name to clipboardExpand all lines: tests/unit/asyncio/test_async_grpc_client.py

+17Lines changed: 17 additions & 0 deletions

Original file line number	Diff line number	Diff line change
@@ -184,6 +184,23 @@ def test_grpc_client_with_anon_creds(
184	184	transport = kwargs["transport"]
185	185	assert isinstance(transport._credentials, AnonymousCredentials)
186	186
	187	+ def test_grpc_client_with_anon_creds_no_client_options(self):
	188	+ # Act & Assert
	189	+ message = "Either client_options or `client_option.api_endpoint` is None. Please provide api_endpoint when `AnonymousCredentials` is used "
	190	+ with pytest.raises(ValueError, match=message):
	191	+ async_grpc_client.AsyncGrpcClient(
	192	+ credentials=AnonymousCredentials(),
	193	+ )
	194	+
	195	+ def test_grpc_client_with_anon_creds_empty_client_options(self):
	196	+ # Act & Assert
	197	+ message = "Either client_options or `client_option.api_endpoint` is None. Please provide api_endpoint when `AnonymousCredentials` is used "
	198	+ with pytest.raises(ValueError, match=message):
	199	+ async_grpc_client.AsyncGrpcClient(
	200	+ client_options=client_options.ClientOptions(),
	201	+ credentials=AnonymousCredentials(),
	202	+ )
	203	+
187	204	@mock.patch("google.cloud._storage_v2.StorageAsyncClient")
188	205	def test_user_agent_with_custom_client_info(self, mock_async_storage_client):
189	206	"""Test that gcloud-python user agent is appended to existing user agent.

0 commit comments

Comments

0 (0)