FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

feat: add support for soft delete by cojenco · Pull Request #1229 · googleapis/python-storage · GitHub

This repository was archived by the owner on Mar 31, 2026. It is now read-only.
/ python-storage Public archive

feat: add support for soft delete - #1229

Merged
cojenco merged 7 commits into
googleapis:mainfrom
cojenco:softdelete
Mar 18, 2024
ConversationCommits (7)ChecksFiles changed
Merged

feat: add support for soft delete#1229
cojenco merged 7 commits into
googleapis:mainfrom
cojenco:softdelete

Conversation

cojenco commented Feb 22, 2024

Copy link
Copy Markdown
Contributor

As part of the soft delete feature, add support to

  • Set a soft delete policy on a new or existing bucket
  • Get a bucket's soft delete policy
  • Get a soft deleted object by doing an object get call with the soft deleted parameter set to true
  • Get the soft delete time and hard delete time metadata fields from a soft deleted object
  • List soft deleted objects by doing an object list call with the soft deleted parameter set to true
  • Restore a soft deleted object

Fixes #1224

cojenco requested review from a team February 22, 2024 23:03
product-auto-label Bot added size: l Pull request size is large. api: storage Issues related to the googleapis/python-storage API. labels Feb 22, 2024
cojenco added the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 23, 2024
gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 23, 2024
JesseLovelace reviewed Feb 26, 2024
View reviewed changes
Comment thread google/cloud/storage/bucket.py Outdated
cojenco added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 6, 2024
yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 6, 2024
cojenco added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 8, 2024
yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 8, 2024
cojenco added the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 8, 2024
gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 8, 2024
cojenco added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Mar 12, 2024
JesseLovelace removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Mar 13, 2024
andrewsg suggested changes Mar 15, 2024
View reviewed changes

andrewsg left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Need an answer to the question about behavior before I can continue with the review. Thanks!

Comment thread google/cloud/storage/_helpers.py Outdated
Comment thread google/cloud/storage/blob.py Outdated
Comment thread google/cloud/storage/blob.py
vishwarajanand reviewed Mar 18, 2024
View reviewed changes
Comment thread tests/system/test_bucket.py
andrewsg suggested changes Mar 18, 2024
View reviewed changes
Comment thread google/cloud/storage/blob.py Outdated
Comment thread google/cloud/storage/_helpers.py Outdated
cojenco requested a review from andrewsg March 18, 2024 18:04
cojenco added the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 18, 2024
gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 18, 2024
andrewsg approved these changes Mar 18, 2024
View reviewed changes

andrewsg left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks!

cojenco merged commit 3928aa0 into googleapis:main Mar 18, 2024
release-please Bot mentioned this pull request Mar 18, 2024
Merged
cojenco deleted the softdelete branch October 30, 2024 00:53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

3 more reviewers
andrewsg andrewsg approved these changes
vishwarajanand vishwarajanand approved these changes
JesseLovelace JesseLovelace approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: storage Issues related to the googleapis/python-storage API. size: l Pull request size is large.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Implement soft delete

5 participants

Back | FazBrowse Home | New Git URL