This repository was archived by the owner on Mar 31, 2026. It is now read-only.
fix: allow signed post policy v4 with service account and token - #1356
Merged
cojenco merged 2 commits intoOct 4, 2024
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
cojenco
marked this pull request as ready for review
October 1, 2024 22:26
andrewsg
approved these changes
Oct 1, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow client.generate_signed_post_policy_v4() to use a service account email and access token.
If service_account_email and access_token is passed in, bypass the signed credentials check.
Note that we are working with partner teams on revamping the signed urls methods and may supersede this change
Fixes #1351 🦕