FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

feat: IAM signBlob retry and universe domain support by cojenco · Pull Request #1380 · googleapis/python-storage · GitHub

This repository was archived by the owner on Mar 31, 2026. It is now read-only.
/ python-storage Public archive

feat: IAM signBlob retry and universe domain support - #1380

Merged
cojenco merged 5 commits into
googleapis:mainfrom
cojenco:retry-iam-sign
Nov 20, 2024
ConversationCommits (5)ChecksFiles changed
Merged

feat: IAM signBlob retry and universe domain support#1380
cojenco merged 5 commits into
googleapis:mainfrom
cojenco:retry-iam-sign

Conversation

cojenco commented Nov 12, 2024

Copy link
Copy Markdown
Contributor

No description provided.

product-auto-label Bot added size: s Pull request size is small. api: storage Issues related to the googleapis/python-storage API. labels Nov 12, 2024
product-auto-label Bot added size: m Pull request size is medium. and removed size: s Pull request size is small. labels Nov 16, 2024
cojenco changed the title feat: IAM signBlob retries feat: IAM signBlob retry and universe domain support Nov 16, 2024
cojenco marked this pull request as ready for review November 18, 2024 20:03
cojenco requested review from a team November 18, 2024 20:03
cojenco added the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 20, 2024
gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 20, 2024
sydney-munro approved these changes Nov 20, 2024
View reviewed changes

sydney-munro left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM, would probably be best if @andrewsg also got a look at it

andrewsg approved these changes Nov 20, 2024
View reviewed changes

andrewsg left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

lgtm!

cojenco added the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 20, 2024
gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 20, 2024
cojenco merged commit abc8061 into googleapis:main Nov 20, 2024
release-please Bot mentioned this pull request Nov 12, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers
andrewsg andrewsg approved these changes
sydney-munro sydney-munro approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

andrewsg

Labels

api: storage Issues related to the googleapis/python-storage API. size: m Pull request size is medium.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL