This repository was archived by the owner on Mar 31, 2026. It is now read-only.
fix: Segmentation fault in tink while writing data - #1490
Merged
Pulkit0110 merged 3 commits intoJun 13, 2025
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
Please add unit tests as per cl/766131162 |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
Sorry, something went wrong.
vasporig
reviewed
Jun 10, 2025
Comment thread
tests/unit/test_fileio.py
vasporig
reviewed
Jun 10, 2025
vasporig
left a comment
Copy link
Copy Markdown
There was a problem hiding this comment.
looks good, please add one more test
Sorry, something went wrong.
vasporig
approved these changes
Jun 12, 2025
chandra-siri
approved these changes
Jun 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Reviewers
2 more reviewersAssignees
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tink doesn't properly validate the value returned by the python output stream's write method. Usually, this value should be smaller than the size of the data. But the write method returns the complete size of the object instead of the size of bytes of the chunk written.