feat(storage): add support of daysSinceNoncurrentTime and noncurrentTimeBefore by HemangChothani · Pull Request #162 · googleapis/python-storage · GitHub

Fixes #159

…imeBefore

…into storage_issue_159

@frankyn Should i change datetime object microsec to millisec as backend save the values in millisec? or any change expected from backend side.

…into storage_issue_159

@HemangChothani does the backend accept microsec? I think in general if the backend accepts it, we can take the easier path for our client and send the value directly.

Please hold pending release.

@jkwlui The backend doesn't throw an error when time sent in microsecond, but when i have tried to retrieve the value it returned in millisecond.

…into storage_issue_159

@jkwlui PTAL! I have remove the custom method as backend accept and return the noncurrentTimeBefore value in microsecond.

…into storage_issue_159

LGTM. Please hold off from merging until we get approvals from the product side. Thank @HemangChothani!

…-storage into storage_issue_159

@jkwlui The 1.29.0 release was made on 2020-06-11. Should this feature be unblocked?

Please don't merge this change. We have an adjustment for the requirements coming that need to be addressed both client side and server side before merging.

…into storage_issue_159

Thanks for your patience @HemangChothani,

Update: The Cloud Storage team has updated type of noncurrent_time_before and custom_time to be a Date format (YYYY-mm-dd) instead of DateTime.

Discovery document with updated documentation with respect to these fields:
https://www.googleapis.com/discovery/v1/apis/storage/v1/rest

Update: The Cloud Storage team has updated type of noncurrent_time_before and custom_time to be a Date format (YYYY-mm-dd) instead of DateTime.

@frankyn That change has been already done.

…into storage_issue_159

Hey @HemangChothani I meant to say:

Update: The Cloud Storage team has updated type of noncurrentTimeBefore and customTimeBefore to be a Date format (YYYY-mm-dd) instead of DateTime.

Discovery document with updated documentation with respect to these fields:
https://www.googleapis.com/discovery/v1/apis/storage/v1/rest

…into storage_issue_159

Documentation nit, otherwise LGTM.

Use RFC3339 and provide an example: 2019-03-16

…-storage into storage_issue_159

…into storage_issue_159

…imeBefore (googleapis#162) * feat(storage): add support of daysSinceNoncurrentTime and noncurrentTimeBefore * feat(storage): fix code coverage * feat(storage): add custom method to convert datetime to string * feat(storage): remove custom method as server support microsec * feat(storage): change the return type of noncurrent_time_before * feat(storage): change non_current_time type from datetime to date * feat: nit Co-authored-by: Jonathan Lui <jonathanlui@google.com> Co-authored-by: Frank Natividad <frankyn@users.noreply.github.com>

HemangChothani added 2 commits May 27, 2020 18:06

feat(storage): add support of daysSinceNoncurrentTime and noncurrentT…

8677bdf

…imeBefore

Merge branch 'master' of https://github.com/googleapis/python-storage …

463c75d

…into storage_issue_159

HemangChothani requested a review from frankyn May 27, 2020 12:39

googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 27, 2020

HemangChothani changed the title Storage issue 159 feat(storage): add support of daysSinceNoncurrentTime and noncurrentTimeBefore May 27, 2020

frankyn requested a review from jkwlui May 27, 2020 16:09

frankyn added status: blocked Resolving the issue is dependent on other work. do not merge Indicates a pull request not ready for merge, due to either quality or timing. and removed status: blocked Resolving the issue is dependent on other work. labels May 27, 2020

HemangChothani added 3 commits May 28, 2020 11:04

feat(storage): fix code coverage

d6351ab

Merge branch 'master' of https://github.com/googleapis/python-storage …

8b5b67f

…into storage_issue_159

feat(storage): add custom method to convert datetime to string

b866ffc

jkwlui suggested changes Jun 4, 2020

View reviewed changes

HemangChothani added 4 commits June 12, 2020 17:44

Merge branch 'master' of https://github.com/googleapis/python-storage …

39ff644

…into storage_issue_159

Merge branch 'master' of https://github.com/googleapis/python-storage …

be50284

…into storage_issue_159

feat(storage): remove custom method as server support microsec

73030c6

Merge branch 'master' of https://github.com/googleapis/python-storage …

1e8c3e0

…into storage_issue_159

HemangChothani and others added 2 commits June 24, 2020 11:25

Merge branch 'master' of https://github.com/googleapis/python-storage …

26c3990

…into storage_issue_159

Merge branch 'master' into storage_issue_159

63f90dd

jkwlui approved these changes Jul 7, 2020

View reviewed changes

tseaver reviewed Jul 16, 2020

View reviewed changes

Comment thread google/cloud/storage/bucket.py Outdated

Comment thread tests/unit/test_bucket.py Outdated

Comment thread tests/unit/test_bucket.py Outdated

HemangChothani added 2 commits July 17, 2020 12:05

feat(storage): change the return type of noncurrent_time_before

f1b3fed

Merge branch 'storage_issue_159' of https://github.com/q-logic/python…

a51ebf0

…-storage into storage_issue_159

tseaver approved these changes Jul 21, 2020

View reviewed changes

busunkim96 closed this Jul 31, 2020

busunkim96 reopened this Jul 31, 2020

HemangChothani added 2 commits August 7, 2020 17:01

feat(storage): change non_current_time type from datetime to date

c314fa2

Merge branch 'master' of https://github.com/googleapis/python-storage …

6ca1e26

…into storage_issue_159

frankyn suggested changes Aug 12, 2020

View reviewed changes

Merge branch 'master' of https://github.com/googleapis/python-storage …

0f25ddf

…into storage_issue_159

Merge branch 'master' of https://github.com/googleapis/python-storage …

465af75

…into storage_issue_159

frankyn suggested changes Aug 24, 2020

View reviewed changes

Merge branch 'master' into storage_issue_159

5494c57

frankyn removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Aug 24, 2020

HemangChothani added 3 commits August 25, 2020 11:15

feat: nit

4b51e38

Merge branch 'storage_issue_159' of https://github.com/q-logic/python…

bd2edda

…-storage into storage_issue_159

Merge branch 'master' of https://github.com/googleapis/python-storage …

c805a01

…into storage_issue_159

frankyn approved these changes Aug 25, 2020

View reviewed changes

frankyn merged commit 136c097 into googleapis:master Aug 25, 2020

release-please Bot mentioned this pull request Jan 12, 2022

chore(main): release 3.0.0 #688

Closed

+                                                      non current.
+                  :type noncurrent_time_before: :class:`datetime.date`
+                  :param noncurrent_time_before: (Optional) Date object parsed from iso8601 valid date, apply

feat(storage): add support of daysSinceNoncurrentTime and noncurrentTimeBefore by HemangChothani · Pull Request #162 · googleapis/python-storage · GitHub

Uh oh!

feat(storage): add support of daysSinceNoncurrentTime and noncurrentTimeBefore - #162

feat(storage): add support of daysSinceNoncurrentTime and noncurrentTimeBefore#162frankyn merged 21 commits intogoogleapis:mastergoogleapis/python-storage:masterfrom MaxxleLLC:storage_issue_159MaxxleLLC/python-storage:storage_issue_159Copy head branch name to clipboard

Conversation

HemangChothani commented May 27, 2020

Uh oh!

HemangChothani commented May 28, 2020

Uh oh!

jkwlui commented Jun 4, 2020

Uh oh!

jkwlui left a comment

Choose a reason for hiding this comment

Uh oh!

HemangChothani commented Jun 5, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

HemangChothani commented Jun 23, 2020

Uh oh!

jkwlui left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tseaver commented Jul 21, 2020

Uh oh!

frankyn commented Jul 21, 2020

Uh oh!

frankyn left a comment

Choose a reason for hiding this comment

Uh oh!

HemangChothani commented Aug 13, 2020

Uh oh!

frankyn commented Aug 14, 2020

Uh oh!

frankyn left a comment

Choose a reason for hiding this comment

Uh oh!

frankyn Aug 24, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

feat(storage): add support of daysSinceNoncurrentTime and noncurrentTimeBefore#162
frankyn merged 21 commits into
googleapis:masterfrom
MaxxleLLC:storage_issue_159

HemangChothani commented Jun 5, 2020 •
edited
Loading

frankyn Aug 24, 2020 •
edited
Loading