FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

feat: add classifiers for python3.9 and remove for python3.5 by HemangChothani · Pull Request #295 · googleapis/python-storage · GitHub

This repository was archived by the owner on Mar 31, 2026. It is now read-only.
/ python-storage Public archive

feat: add classifiers for python3.9 and remove for python3.5 - #295

Merged
tseaver merged 9 commits into
googleapis:masterfrom
MaxxleLLC:storage_issue_292
Nov 13, 2020
Merged

feat: add classifiers for python3.9 and remove for python3.5#295
tseaver merged 9 commits into
googleapis:masterfrom
MaxxleLLC:storage_issue_292

Conversation

Copy link
Copy Markdown
Contributor

Towards #292

  • nox.py file is generated by synthtool, so didn't include changes here.

google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 15, 2020
HemangChothani linked an issue Oct 15, 2020 that may be closed by this pull request

Copy link
Copy Markdown
Contributor

Will this refuse to install on Python 2.7 or will it just no longer be recommended?

frankyn added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 15, 2020
yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 15, 2020

tseaver commented Nov 11, 2020

Copy link
Copy Markdown
Contributor

@andrewsg The following will refuse to install on 2.7, at least with any recent setuptools:

    python_requires=">=3.6",

This definitely needs to get merged as a breaking change.

Copy link
Copy Markdown
Contributor

I'd recommend waiting to remove Python 2 until other breaking changes. At this time supporting Python 2 isn't providing any drag, but I think once it is we can remove it. @andrewsg @frankyn do we know of any changes that are also breaking to bundle?

Comment thread noxfile.py Outdated
Comment thread setup.py
Comment thread setup.py Outdated
tseaver added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 13, 2020
yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 13, 2020
tseaver changed the title feat: add classifiers for python3.9 and remove for python2.7 and 3.5 feat: add classifiers for python3.9 and remove for python3.5 Nov 13, 2020
tseaver added the automerge Merge the pull request once unit tests and other checks pass. label Nov 13, 2020
tseaver merged commit f072825 into googleapis:master Nov 13, 2020
gcf-merge-on-green Bot removed the automerge Merge the pull request once unit tests and other checks pass. label Nov 13, 2020
cojenco pushed a commit to cojenco/python-storage that referenced this pull request Oct 13, 2021
…pis#295)

Co-authored-by: Frank Natividad <frankyn@users.noreply.github.com>
Co-authored-by: Tres Seaver <tseaver@palladion.com>
cojenco pushed a commit to cojenco/python-storage that referenced this pull request Oct 13, 2021
…pis#295)

Co-authored-by: Frank Natividad <frankyn@users.noreply.github.com>
Co-authored-by: Tres Seaver <tseaver@palladion.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add test pass, classifiers for Python 3.9

6 participants


Back | FazBrowse Home | New Git URL