This repository was archived by the owner on Mar 31, 2026. It is now read-only.
fix: allow signed url version v4 without signed credentials - #356
Merged
frankyn merged 9 commits intoFeb 19, 2021
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
…e checks for efficiency in case of neither access_token nor service_account_email are provided. Fix: tests v4 with token to take into account not Signing credential class.
tseaver
previously requested changes
Jan 20, 2021
Copy link
Copy Markdown
|
I really want this! |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
Sorry for the delay, the week was awful! |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
@tseaver any review possible on this? |
Sorry, something went wrong.
frankyn
approved these changes
Feb 18, 2021
frankyn
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Thanks @guillaumeblaquiere LGTM
Sorry, something went wrong.
This was referenced Mar 11, 2021
Merged
Merged
cojenco
pushed a commit
to cojenco/python-storage
that referenced
this pull request
Oct 13, 2021
…is#356) * Fix: signed_url_v4 to accept credentials without private key. Preserve checks for efficiency in case of neither access_token nor service_account_email are provided. Fix: tests v4 with token to take into account not Signing credential class. * fix typo: 2 new lines before new test class * fix doc: Improve docstring to explain the use of the access_token AND the service_account_email, or the signer email. * fix: test coverage with the new IF branch * lint Co-authored-by: Tres Seaver <tseaver@palladion.com> Co-authored-by: Frank Natividad <frankyn@users.noreply.github.com> Co-authored-by: Frank Natividad <franknatividad@google.com>
cojenco
pushed a commit
to cojenco/python-storage
that referenced
this pull request
Oct 13, 2021
…is#356) * Fix: signed_url_v4 to accept credentials without private key. Preserve checks for efficiency in case of neither access_token nor service_account_email are provided. Fix: tests v4 with token to take into account not Signing credential class. * fix typo: 2 new lines before new test class * fix doc: Improve docstring to explain the use of the access_token AND the service_account_email, or the signer email. * fix: test coverage with the new IF branch * lint Co-authored-by: Tres Seaver <tseaver@palladion.com> Co-authored-by: Frank Natividad <frankyn@users.noreply.github.com> Co-authored-by: Frank Natividad <franknatividad@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #355 🦕
I used the service_account_email passed in method parameter as "signer" instead of taking it in the credentials.signer_email method. That allows to not use google.auth.credentials.Signing type as credential parameter and to use the Service Account credential API instead.
I preserved the checks in case of access_token or service_account_email set to nil, to preserve the efficiency and the existing behavior.
I also updated tests. Successful with python 3.8.
Open to comment and to improve this PR if needed