feat: add preconditions and retry configuration to blob.create_resumable_upload_session - #484
feat: add preconditions and retry configuration to blob.create_resumable_upload_session#484cojenco merged 3 commits into
Conversation
Sorry, something went wrong.
tritone
left a comment
There was a problem hiding this comment.
Generally looks good. Did you test against the emulator that things are working?
Sorry, something went wrong.
| def test_create_resumable_upload_session_with_conditional_retry_failure(self): | ||
| self._create_resumable_upload_session_helper( | ||
| retry=DEFAULT_RETRY_IF_GENERATION_SPECIFIED | ||
| ) |
There was a problem hiding this comment.
How does this test verify that retries don't happen?
Sorry, something went wrong.
There was a problem hiding this comment.
@tritone, I've tested the retry behaviors against the emulator that things are working as intended. The unit test asserts if the mock call was made with the corresponding url and query params.
Sorry, something went wrong.
There was a problem hiding this comment.
Sounds good!
Sorry, something went wrong.
…ble_upload_session (googleapis#484) * feat: add preconditions and retry configuration to blob.create_resumable_upload_session * move imports
…ble_upload_session (googleapis#484) * feat: add preconditions and retry configuration to blob.create_resumable_upload_session * move imports
This adds preconditions and retry configuration to the upload entry method blob.create_resumable_upload_session(), in the continuation of #447 and #480.
This exposes the method to preconditions and therefore can make the operation conditional. It can also be configured with Retry objects and ConditionalRetryPolicy objects.