This repository was archived by the owner on Mar 31, 2026. It is now read-only.
fix: check response code in batch.finish - #609
Merged
cojenco merged 2 commits intoSep 30, 2021
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
cojenco
marked this pull request as ready for review
September 30, 2021 18:22
tseaver
approved these changes
Sep 30, 2021
andrewsg
approved these changes
Sep 30, 2021
cojenco
added a commit
to cojenco/python-storage
that referenced
this pull request
Oct 13, 2021
* add top-level response status code check to batch.finish * test exception is raised when batch request fails
cojenco
added a commit
to cojenco/python-storage
that referenced
this pull request
Oct 13, 2021
* add top-level response status code check to batch.finish * test exception is raised when batch request fails
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a check to the top-level response code in batch.finish so that an exception is raised with the underlying error.
Fixes #608 Fixes #404 🦕