| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
| "expiration": policy_expires.isoformat() + "Z", | ||
| }.items() | ||
| ) | ||
| ), |
There was a problem hiding this comment.
expiration sometimes encoded before conditions - in such a cases tests are failing
Sorry, something went wrong.
There was a problem hiding this comment.
I'm a little concerned about imposing order in signing code given it's only used for conformance tests.
However, it doesn't change the outcome of expectation and will work as expected as a user.
Sorry, something went wrong.
| out_data = test_data["policyOutput"] | ||
|
|
||
| decoded_policy = base64.b64decode(fields["policy"]).decode("unicode_escape") | ||
| assert decoded_policy == out_data["expectedDecodedPolicy"] |
There was a problem hiding this comment.
Moved decoded_policy assert to the top: if something gone wrong in policy, it'll be easier to see it in decoded state - probably will save some time on debugging
Sorry, something went wrong.
|
@frankyn, kokoro failed in TestStorageCompose.test_compose_create_new_blob_wo_content_type. Not related I assume _______ TestStorageCompose.test_compose_create_new_blob_wo_content_type ________
self = <test_system.TestStorageCompose testMethod=test_compose_create_new_blob_wo_content_type>
def test_compose_create_new_blob_wo_content_type(self):
SOURCE_1 = b"AAA\n"
source_1 = self.bucket.blob("source-1")
> source_1.upload_from_string(SOURCE_1)
tests/system/test_system.py:1176:
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
google/cloud/storage/blob.py:1435: in upload_from_string
self.upload_from_file(
google/cloud/storage/blob.py:1344: in upload_from_file
_raise_from_invalid_response(exc)
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
error = InvalidResponse('Request failed with status code', 403, 'Expected one of', <HTTPStatus.OK: 200>)
def _raise_from_invalid_response(error):
"""Re-wrap and raise an ``InvalidResponse`` exception.
:type error: :exc:`google.resumable_media.InvalidResponse`
:param error: A caught exception from the ``google-resumable-media``
library.
:raises: :class:`~google.cloud.exceptions.GoogleCloudError` corresponding
to the failed status code
"""
response = error.response
error_message = str(error)
message = u"{method} {url}: {error}".format(
method=response.request.method, url=response.request.url, error=error_message
)
> raise exceptions.from_http_status(response.status_code, message, response=response)
E google.api_core.exceptions.Forbidden: 403 POST https://storage.googleapis.com/upload/storage/v1/b/new_1585772487875/o?uploadType=multipart: ('Request failed with status code', 403, 'Expected one of', <HTTPStatus.OK: 200>)
|
Sorry, something went wrong.
| "expiration": policy_expires.isoformat() + "Z", | ||
| }.items() | ||
| ) | ||
| ), |
There was a problem hiding this comment.
I'm a little concerned about imposing order in signing code given it's only used for conformance tests.
However, it doesn't change the outcome of expectation and will work as expected as a user.
Sorry, something went wrong.
* use OrderedDict() while encoding POST policy * fix(storage): use OrderedDict() while encoding POST policy
* use OrderedDict() while encoding POST policy * fix(storage): use OrderedDict() while encoding POST policy
| Back | FazBrowse Home | New Git URL |
Towards #64 (comment)
Sometimes policy losses it's order while encoding into JSON. Adding OrderedDict() to fix this.