FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Add Modrinth mod/modpack support by Pyroglyph · Pull Request #1391 · gorilla-devs/GDLauncher · GitHub

This repository was archived by the owner on Aug 21, 2026. It is now read-only.
/ GDLauncher Public archive

Add Modrinth mod/modpack support - #1391

Draft
Pyroglyph wants to merge 8 commits into
gorilla-devs:masterfrom
Pyroglyph:modrinth
Draft

Pyroglyph wants to merge 8 commits into
gorilla-devs:masterfrom
Pyroglyph:modrinth

Conversation

Pyroglyph commented Jul 4, 2022
edited
Loading

Copy link
Copy Markdown

(This picks up where #1352 left off after the big history clean)

Purpose

Currently, GDLauncher does not support downloading mods/modpacks hosted on the Modrinth platform. This feature has been requested in issue #768.

I'm aware of GDevs' other project ferium which already supports Modrinth, and also the gdlib-refactor branch (which I assume may eventually succeed GDLauncher?), but that branch is far from completion.

Approach

This PR allows users to search for and install mods and modpacks hosted on Modrinth in the same way that they can currently be installed from CurseForge and FTB.

The implementation is highly based on the existing CurseForge/FTB installer code so it adds no new dependencies, which I see as an advantage.

Open Questions and Pre-Merge TODOs

  • Add support for searching for and installing modpacks from Modrinth
  • Add support for searching for and installing individual mods from Modrinth
  • Add a proper way to show errors to the user (i.e. when a mod fails to download, or when the user tried to install an unsupported pack type like Quilt)
  • Modrinth provides fallback download links for overrides. If an override file fails to download, the launcher should retry the download using given alternate links.
  • Waiting on Add Quilt Support #1400 so we can take immediate advantage of Modrinth's Quilt packs

Learning

I have read the Modrinth API docs (linked below).

Resources

Squashed from Pyroglyph/GDLauncher/tree/modrinth-support
Eskaan added the Type: Feature Requests to add a feature to the app label Jul 5, 2022

Copy link
Copy Markdown

Modrinth said on Twitter that api user should have a User-Agent.
Here the documentation: https://docs.modrinth.com/api-spec/#section/User-Agents

Copy link
Copy Markdown

I found some issues with the build #1746 can you tell me if you fixed them or not?
Here are the issues:

  1. Mods manager doesn't automatically detect the modloader to download mods
  2. Mods manager doesn't automatically detect which version of minecraft you are on
    I hope you can fix these issues, even if you said you were waiting for the other pull request to be done.

Copy link
Copy Markdown
Author

@AshtakaOOf
While trying to check for those issues I found a few more, so it seems I still have more work to do on this.

Copy link
Copy Markdown

I would definetly recommend getting it working as soon as possible as more and more mods are moving to Modrinth

Copy link
Copy Markdown

Would recommend just adding a pull request after this to add QuiltMC support to the patch because there's been no activity on that pull request and alot of big mods are moving and it's starting to really get annoying

Ecorous commented Aug 4, 2022

Copy link
Copy Markdown

Would recommend just adding a pull request after this to add QuiltMC support to the patch because there's been no activity on that pull request and alot of big mods are moving and it's starting to really get annoying

Me and Pyro had already talked about this before I started the PR :P

Pyroglyph commented Sep 7, 2022
edited
Loading

Copy link
Copy Markdown
Author

I've come back after a few weeks off this project and suddenly it wasn't working. I did some investigation and found that when I merged this commit caused a total freeze (but not a crash) when opening the Manage window of an instance. It happens on both Windows and Linux on 2 different machines, so it's not isolated. I haven't figured out why yet.

I've rewritten the history of my branch to remove the times I merged from the master branch and that has stopped the issue, hence the recent force push.

Edit: The commit I mentioned earlier is the problem. Merging the latest master in breaks it, reverting that commit fixes it.

Eskaan linked an issue Sep 9, 2022 that may be closed by this pull request

Copy link
Copy Markdown

Hello! I was wondering if you had any leads as to what the issue is? I wanted to take a crack at it and I'm curious if there was any work already put into resolving it.

lpuv commented Dec 15, 2022

Copy link
Copy Markdown

Hi! Any progress on this?

Copy link
Copy Markdown

Status...?

Iris has just been removed from CurseForge... now would be THE time to get on with this.

Copy link
Copy Markdown

Please stop waiting on the Quilt pull. Nothing is happening with it

Copy link
Copy Markdown

Are we still waiting for the Qulit support?

blarfoon commented Jul 1, 2023

Copy link
Copy Markdown
Member

Quilt has been added already to the rewrite. We will release it in open beta by end of August.

Copy link
Copy Markdown


Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

1 similar comment

Copy link
Copy Markdown


Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Type: Feature Requests to add a feature to the app

Projects

None yet

Development

Successfully merging this pull request may close these issues.

support modrinth

Back | FazBrowse Home | New Git URL