gh-115914: minor cleanup: simplify filename_obj assignment in PyRun_… · guyjacoby/cpython@f082a05 · GitHub

1. guyjacoby
2. cpython

Repository navigation

• Code
• Pull requests
• Actions
• Projects
• Security and quality
• Insights

Commit f082a05

Browse filesBrowse the repository at this point in the historyBrowse files

gorsing

authored

pythongh-115914: minor cleanup: simplify filename_obj assignment in PyRun_AnyFileExFlags (pythongh-115916)

This simplifies the code: less lines, easier to read. Logically equivalent, as any compiler likely already determined.

1 parent 84a275c commit f082a05
Copy full SHA for f082a05

1 file changed

+1-4Lines changed: 1 addition & 4 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• Python
  • pythonrun.c

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎Python/pythonrun.c‎

Copy file name to clipboardExpand all lines: Python/pythonrun.c

+1-4Lines changed: 1 addition & 4 deletions

Original file line number	Diff line number	Diff line change
@@ -89,17 +89,14 @@ int
89	89	PyRun_AnyFileExFlags(FILE *fp, const char *filename, int closeit,
90	90	PyCompilerFlags *flags)
91	91	{
92		- PyObject *filename_obj;
	92	+ PyObject *filename_obj = NULL;
93	93	if (filename != NULL) {
94	94	filename_obj = PyUnicode_DecodeFSDefault(filename);
95	95	if (filename_obj == NULL) {
96	96	PyErr_Print();
97	97	return -1;
98	98	}
99	99	}
100		- else {
101		- filename_obj = NULL;
102		- }
103	100	int res = _PyRun_AnyFileObject(fp, filename_obj, closeit, flags);
104	101	Py_XDECREF(filename_obj);
105	102	return res;

0 commit comments

Comments

0 (0)