| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -25,10 +25,11 @@ X https://github.com/processing/processing/pull/3658 | |||
| 25 | 25 | X implement frameRate() | |
| 26 | 26 | X FX - Fix key typed | |
| 27 | 27 | X https://github.com/processing/processing/pull/3672 | |
| 28 | - | ||
| 29 | - java.lang.StringIndexOutOfBoundsException: String index out of range: 0 | ||
| 30 | - at java.lang.String.charAt(String.java:658) | ||
| 31 | - at processing.javafx.PSurfaceFX.fxKeyEvent(PSurfaceFX.java:713) | ||
| 28 | + X FX - Make key events little bit more sane | ||
| 29 | + X https://github.com/processing/processing/pull/3686 | ||
| 30 | + X added note about AIOOBE seen earlier | ||
| 31 | + X Update LowLevelGL to use VBOs | ||
| 32 | + X https://github.com/processing/processing-docs/pull/289 | ||
| 32 | 33 | ||
| 33 | 34 | ||
| 34 | 35 | known issues | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -40,7 +40,6 @@ | |||
| 40 | 40 | import processing.app.Sketch; | |
| 41 | 41 | import processing.app.SketchCode; | |
| 42 | 42 | import processing.app.Util; | |
| 43 | - import processing.mode.java.pdex.ErrorCheckerService; | ||
| 44 | 43 | import processing.mode.java.pdex.LineMarker; | |
| 45 | 44 | import processing.mode.java.pdex.Problem; | |
| 46 | 45 | import processing.app.Language; | |
@@ -57,13 +56,8 @@ | |||
| 57 | 56 | */ | |
| 58 | 57 | public class MarkerColumn extends JPanel { | |
| 59 | 58 | protected JavaEditor editor; | |
| 60 | - protected ErrorCheckerService errorCheckerService; | ||
| 61 | 59 | ||
| 62 | 60 | static final int WIDE = 12; | |
| 63 | - // protected int preferredHeight; | ||
| 64 | - // protected int preferredWidth = 12; | ||
| 65 | - | ||
| 66 | - // static final int errorMarkerHeight = 4; | ||
| 67 | 61 | ||
| 68 | 62 | private Color errorColor; | |
| 69 | 63 | private Color warningColor; | |
@@ -73,13 +67,9 @@ public class MarkerColumn extends JPanel { | |||
| 73 | 67 | private List<LineMarker> errorPoints = | |
| 74 | 68 | Collections.synchronizedList(new ArrayList<LineMarker>()); | |
| 75 | 69 | ||
| 76 | - // /** Stores previous list of error markers. */ | ||
| 77 | - // private List<LineMarker> errorPointsOld = new ArrayList<LineMarker>(); | ||
| 78 | - | ||
| 79 | 70 | ||
| 80 | 71 | public MarkerColumn(JavaEditor editor, int height) { | |
| 81 | 72 | this.editor = editor; | |
| 82 | - this.errorCheckerService = editor.errorCheckerService; | ||
| 83 | 73 | ||
| 84 | 74 | Mode mode = editor.getMode(); | |
| 85 | 75 | errorColor = mode.getColor("editor.column.error.color"); | |
@@ -121,10 +111,9 @@ public List<LineMarker> getErrorPoints() { | |||
| 121 | 111 | ||
| 122 | 112 | ||
| 123 | 113 | synchronized public void updateErrorPoints(final List<Problem> problems) { | |
| 124 | - // NOTE TO SELF: ErrorMarkers are calculated for the present tab only | ||
| 125 | - // Error Marker index in the arraylist is LOCALIZED for current tab. | ||
| 126 | - // Also, need to do the update in the UI thread via SwingWorker to prevent | ||
| 127 | - // concurrency issues. | ||
| 114 | + // NOTE: ErrorMarkers are calculated for the present tab only Error Marker | ||
| 115 | + // index in the arraylist is LOCALIZED for current tab. Also, update is in | ||
| 116 | + // the UI thread via SwingWorker to prevent concurrency issues. [Manindra] | ||
| 128 | 117 | try { | |
| 129 | 118 | new SwingWorker() { | |
| 130 | 119 | protected Object doInBackground() throws Exception { | |
@@ -168,30 +157,6 @@ protected void done() { | |||
| 168 | 157 | } | |
| 169 | 158 | ||
| 170 | 159 | ||
| 171 | - /* | ||
| 172 | - // Check if new errors have popped up in the sketch since the last check | ||
| 173 | - public boolean errorPointsChanged() { | ||
| 174 | - if (errorPointsOld.size() != errorPoints.size()) { | ||
| 175 | - editor.getTextArea().repaint(); | ||
| 176 | - // System.out.println("2 Repaint " + System.currentTimeMillis()); | ||
| 177 | - return true; | ||
| 178 | - } | ||
| 179 | - | ||
| 180 | - else { | ||
| 181 | - for (int i = 0; i < errorPoints.size(); i++) { | ||
| 182 | - if (errorPoints.get(i).getY() != errorPointsOld.get(i).getY()) { | ||
| 183 | - editor.getTextArea().repaint(); | ||
| 184 | - // System.out.println("3 Repaint " + | ||
| 185 | - // System.currentTimeMillis()); | ||
| 186 | - return true; | ||
| 187 | - } | ||
| 188 | - } | ||
| 189 | - } | ||
| 190 | - return false; | ||
| 191 | - } | ||
| 192 | - */ | ||
| 193 | - | ||
| 194 | - | ||
| 195 | 160 | /** Find out which error/warning the user has clicked and scroll to it */ | |
| 196 | 161 | void scrollToMarkerAt(final int y) { | |
| 197 | 162 | try { | |
@@ -201,7 +166,7 @@ protected Object doInBackground() throws Exception { | |||
| 201 | 166 | // -2 and +2 are extra allowance, clicks in the | |
| 202 | 167 | // vicinity of the markers register that way | |
| 203 | 168 | if (Math.abs(y - m.getY()) < 3) { | |
| 204 | - errorCheckerService.scrollToErrorLine(m.getProblem()); | ||
| 169 | + editor.getErrorChecker().scrollToErrorLine(m.getProblem()); | ||
| 205 | 170 | return null; | |
| 206 | 171 | } | |
| 207 | 172 | } | |
| Back | FazBrowse Home | New Git URL |
0 commit comments