Merge pull request #3521 from NativeScript/fix-android-statusbar-crash · hettiger/NativeScript@f228548 · GitHub

1. hettiger
2. NativeScript

Repository navigation

• Code
• Pull requests
• Actions
• Projects
• Wiki
• Security and quality
• Insights

Commit f228548

Browse filesBrowse the repository at this point in the historyBrowse files

PanayotCankov

authored

Merge pull request NativeScript#3521 from NativeScript/fix-android-statusbar-crash

Fix crash when status bar is set on Android in API level 21 or below

2 parents 7142fc0 + 74d5510 commit f228548
Copy full SHA for f228548

1 file changed

+10-6Lines changed: 10 additions & 6 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• tns-core-modules/ui/page
  • page.android.ts

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎tns-core-modules/ui/page/page.android.ts‎

Copy file name to clipboardExpand all lines: tns-core-modules/ui/page/page.android.ts

+10-6Lines changed: 10 additions & 6 deletions

Original file line number	Diff line number	Diff line change
@@ -243,15 +243,19 @@ export class PageStyler implements style.Styler {
243	243
244	244	// android-status-bar-background-property
245	245	private static setAndroidStatusBarBackgroundProperty(v: view.View, newValue: any) {
246		- let window = app.android.startActivity.getWindow();
247		- let nativeColor = new colorModule.Color(newValue).android;
248		- window.setStatusBarColor(nativeColor);
	246	+ if (platform.device.sdkVersion >= "21") {
	247	+ let window = app.android.startActivity.getWindow();
	248	+ let nativeColor = new colorModule.Color(newValue).android;
	249	+ window.setStatusBarColor(nativeColor);
	250	+ }
249	251	}
250	252
251	253	private static resetAndroidStatusBarBackgroundProperty(v: view.View, nativeValue: any) {
252		- let window = app.android.startActivity.getWindow();
253		- let nativeColor = (nativeValue instanceof colorModule.Color) ? (<colorModule.Color>nativeValue).android : new colorModule.Color(nativeValue).android;
254		- window.setStatusBarColor(nativeColor);
	254	+ if (platform.device.sdkVersion >= "21") {
	255	+ let window = app.android.startActivity.getWindow();
	256	+ let nativeColor = (nativeValue instanceof colorModule.Color) ? (<colorModule.Color>nativeValue).android : new colorModule.Color(nativeValue).android;
	257	+ window.setStatusBarColor(nativeColor);
	258	+ }
255	259	}
256	260
257	261	private static getAndroidStatusBarBackgroundProperty(v: view.View): any {

0 commit comments

Comments

0 (0)