Test suggestion box behavior before/after #466. · ii0/bpython@aa4ff42 · GitHub

ii0 / bpython Public

forked from bpython/bpython

• Notifications You must be signed in to change notification settings
• Fork 0
• Star 0

• Code
• Pull requests
• Actions
• Projects
• Wiki
• Security and quality
• Insights

Additional navigation options

Commit aa4ff42

Browse filesBrowse the repository at this point in the historyBrowse files

thomasballinger

committed

Test suggestion box behavior before/after bpython#466.

1 parent 66c5771 commit aa4ff42
Copy full SHA for aa4ff42

2 files changed

+28-4Lines changed: 28 additions & 4 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• bpython
  • curtsiesfrontend
    • repl.py
  • test
    • test_curtsies_painting.py

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎bpython/curtsiesfrontend/repl.py‎

Copy file name to clipboardExpand all lines: bpython/curtsiesfrontend/repl.py

+2-2Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
@@ -1252,8 +1252,8 @@ def current_output_line(self, value):
1252	1252	self.stdin.current_line = '\n'
1253	1253
1254	1254	def paint(self, about_to_exit=False, user_quit=False,
1255		- try_preserve_history_height=40,
1256		- min_infobox_height=4):
	1255	+ try_preserve_history_height=30,
	1256	+ min_infobox_height=5):
1257	1257	"""Returns an array of min_height or more rows and width columns, plus
1258	1258	cursor position
1259	1259

Collapse file

‎bpython/test/test_curtsies_painting.py‎

Copy file name to clipboardExpand all lines: bpython/test/test_curtsies_painting.py

+26-2Lines changed: 26 additions & 2 deletions

Original file line number	Diff line number	Diff line change
@@ -696,7 +696,19 @@ def test_lower_on_screen(self):
696	696	'| k |',
697	697	'| l |',
698	698	'+------------------+']
699		- self.assert_paint_ignoring_formatting(screen, (0, 8))
	699	+ # behavior before issue #466
	700	+ self.assert_paint_ignoring_formatting(
	701	+ screen, try_preserve_history_height=0)
	702	+ self.assert_paint_ignoring_formatting(
	703	+ screen, min_infobox_height=100)
	704	+ # behavior after issue #466
	705	+ screen = ['>>> abc.',
	706	+ '+------------------+',
	707	+ '| aaaaaaaaaaaaaaaa |',
	708	+ '| b |',
	709	+ '| c |',
	710	+ '+------------------+']
	711	+ self.assert_paint_ignoring_formatting(screen)
700	712
701	713	def test_at_bottom_of_screen(self):
702	714	self.repl.get_top_usable_line = lambda: 17 # two lines from bottom
@@ -720,4 +732,16 @@ def test_at_bottom_of_screen(self):
720	732	'| k |',
721	733	'| l |',
722	734	'+------------------+']
723		- self.assert_paint_ignoring_formatting(screen, (0, 8))
	735	+ # behavior before issue #466
	736	+ self.assert_paint_ignoring_formatting(
	737	+ screen, try_preserve_history_height=0)
	738	+ self.assert_paint_ignoring_formatting(
	739	+ screen, min_infobox_height=100)
	740	+ # behavior after issue #466
	741	+ screen = ['>>> abc.',
	742	+ '+------------------+',
	743	+ '| aaaaaaaaaaaaaaaa |',
	744	+ '| b |',
	745	+ '| c |',
	746	+ '+------------------+']
	747	+ self.assert_paint_ignoring_formatting(screen)

0 commit comments

Comments

0 (0)