fix(help): custom colors are not passed to SchemaHelpFormatter (#4115) · ionic-team/ionic-cli@5634e9f · GitHub

1. ionic-team
2. ionic-cli

Repository navigation

• Code
• Issues344 (344)
• Pull requests24 (24)
• Actions
• Wiki
• Security and quality
• Insights

Commit 5634e9f

Browse filesBrowse the repository at this point in the historyBrowse files

thesayyn

authored and

imhoffd

committed

fix(help): custom colors are not passed to SchemaHelpFormatter (#4115)

1 parent 84a6b7f commit 5634e9f
Copy full SHA for 5634e9f

1 file changed

+4-4Lines changed: 4 additions & 4 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• packages/@ionic/cli-framework/src/lib
  • executor.ts

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎packages/@ionic/cli-framework/src/lib/executor.ts‎

Copy file name to clipboardExpand all lines: packages/@ionic/cli-framework/src/lib/executor.ts

+4-4Lines changed: 4 additions & 4 deletions

Original file line number	Diff line number	Diff line change
@@ -124,10 +124,10 @@ export class BaseExecutor<C extends ICommand<C, N, M, I, O>, N extends INamespac
124	124	let formatter: HelpFormatter;
125	125
126	126	if (isCommand(location.obj)) {
127		- const options = { location, command: location.obj };
	127	+ const options = { location, command: location.obj, colors: this.colors };
128	128	formatter = format === 'json' ? new CommandSchemaHelpFormatter(options) : new CommandStringHelpFormatter(options);
129	129	} else {
130		- const options = { location, namespace: location.obj };
	130	+ const options = { location, namespace: location.obj, colors: this.colors };
131	131	formatter = format === 'json' ? new NamespaceSchemaHelpFormatter(options) : new NamespaceStringHelpFormatter(options);
132	132	}
133	133
@@ -150,8 +150,8 @@ export class BaseExecutor<C extends ICommand<C, N, M, I, O>, N extends INamespac
150	150	const location = await this.namespace.locate(cmdpath);
151	151
152	152	const formatter = isCommand(location.obj)
153		- ? new CommandSchemaHelpFormatter({ location, command: location.obj })
154		- : new NamespaceSchemaHelpFormatter({ location, namespace: location.obj });
	153	+ ? new CommandSchemaHelpFormatter({ location, command: location.obj, colors: this.colors })
	154	+ : new NamespaceSchemaHelpFormatter({ location, namespace: location.obj, colors: this.colors });
155	155
156	156	return formatter.serialize();
157	157	});

0 commit comments

Comments

0 (0)