Issue #4740: Use HIGHEST_PROTOCOL in pickle test. · java66liu/python@75a8b72 · GitHub

java66liu / python Public

forked from glix/python

• Notifications You must be signed in to change notification settings
• Fork 0
• Star 0

• Code
• Pull requests
• Actions
• Projects
• Wiki
• Security and quality
• Insights

Additional navigation options

Commit 75a8b72

Browse filesBrowse the repository at this point in the historyBrowse files

hirokazu.yamamoto

committed

Issue #4740: Use HIGHEST_PROTOCOL in pickle test.

(There is no behavior difference in 2.x because HIGHEST_PROTOCOL == 2) git-svn-id: http://svn.python.org/projects/python/trunk@67930 6015fed2-1504-0410-9fe1-9d1591cc4771

1 parent a5df2e2 commit 75a8b72
Copy full SHA for 75a8b72

3 files changed

+6-6Lines changed: 6 additions & 6 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• Lib/test
  • test_array.py
  • test_deque.py
  • test_set.py

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎Lib/test/test_array.py‎

Copy file name to clipboardExpand all lines: Lib/test/test_array.py

+3-3Lines changed: 3 additions & 3 deletions

Original file line number	Diff line number	Diff line change
@@ -7,7 +7,7 @@
7	7	from test import test_support
8	8	from weakref import proxy
9	9	import array, cStringIO
10		- from cPickle import loads, dumps
	10	+ from cPickle import loads, dumps, HIGHEST_PROTOCOL
11	11
12	12	class ArraySubclass(array.array):
13	13	pass
@@ -97,7 +97,7 @@ def test_deepcopy(self):
97	97	self.assertEqual(a, b)
98	98
99	99	def test_pickle(self):
100		- for protocol in (0, 1, 2):
	100	+ for protocol in range(HIGHEST_PROTOCOL + 1):
101	101	a = array.array(self.typecode, self.example)
102	102	b = loads(dumps(a, protocol))
103	103	self.assertNotEqual(id(a), id(b))
@@ -112,7 +112,7 @@ def test_pickle(self):
112	112	self.assertEqual(type(a), type(b))
113	113
114	114	def test_pickle_for_empty_array(self):
115		- for protocol in (0, 1, 2):
	115	+ for protocol in range(HIGHEST_PROTOCOL + 1):
116	116	a = array.array(self.typecode)
117	117	b = loads(dumps(a, protocol))
118	118	self.assertNotEqual(id(a), id(b))

Collapse file

‎Lib/test/test_deque.py‎

Copy file name to clipboardExpand all lines: Lib/test/test_deque.py

+2-2Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
@@ -373,7 +373,7 @@ def test_roundtrip_iter_init(self):
373	373
374	374	def test_pickle(self):
375	375	d = deque(xrange(200))
376		- for i in (0, 1, 2):
	376	+ for i in range(pickle.HIGHEST_PROTOCOL + 1):
377	377	s = pickle.dumps(d, i)
378	378	e = pickle.loads(s)
379	379	self.assertNotEqual(id(d), id(e))
@@ -382,7 +382,7 @@ def test_pickle(self):
382	382	## def test_pickle_recursive(self):
383	383	## d = deque('abc')
384	384	## d.append(d)
385		- ## for i in (0, 1, 2):
	385	+ ## for i in range(pickle.HIGHEST_PROTOCOL + 1):
386	386	## e = pickle.loads(pickle.dumps(d, i))
387	387	## self.assertNotEqual(id(d), id(e))
388	388	## self.assertEqual(id(e), id(e[-1]))

Collapse file

‎Lib/test/test_set.py‎

Copy file name to clipboardExpand all lines: Lib/test/test_set.py

+1-1Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -221,7 +221,7 @@ def test_sub_and_super(self):
221	221	self.failIf(set('cbs').issuperset('a'))
222	222
223	223	def test_pickling(self):
224		- for i in (0, 1, 2):
	224	+ for i in range(pickle.HIGHEST_PROTOCOL + 1):
225	225	p = pickle.dumps(self.s, i)
226	226	dup = pickle.loads(p)
227	227	self.assertEqual(self.s, dup, "%s != %s" % (self.s, dup))

0 commit comments

Comments

0 (0)