Merge pull request #402 from android/nb/js_anim_launch · jcode9/compose-samples@e3bd277 · GitHub

jcode9 / compose-samples Public

forked from android/compose-samples

• Notifications You must be signed in to change notification settings
• Fork 0
• Star 0

• Code
• Pull requests
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit e3bd277

Browse filesBrowse the repository at this point in the historyBrowse files

nickbutcher

authored

Merge pull request android#402 from android/nb/js_anim_launch

[Jetsnack] Correct creation of coroutines within composition.

2 parents d3e192c + 4e81ef5 commit e3bd277
Copy full SHA for e3bd277

1 file changed

+2-7Lines changed: 2 additions & 7 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• Jetsnack/app/src/main/java/com/example/jetsnack/ui/home
  • Home.kt

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎Jetsnack/app/src/main/java/com/example/jetsnack/ui/home/Home.kt‎

Copy file name to clipboardExpand all lines: Jetsnack/app/src/main/java/com/example/jetsnack/ui/home/Home.kt

+2-7Lines changed: 2 additions & 7 deletions

Original file line number	Diff line number	Diff line change
@@ -46,7 +46,6 @@ import androidx.compose.runtime.LaunchedEffect
46	46	import androidx.compose.runtime.getValue
47	47	import androidx.compose.runtime.mutableStateOf
48	48	import androidx.compose.runtime.remember
49		- import androidx.compose.runtime.rememberCoroutineScope
50	49	import androidx.compose.runtime.saveable.rememberSaveable
51	50	import androidx.compose.ui.Alignment
52	51	import androidx.compose.ui.Modifier
@@ -75,7 +74,6 @@ import com.example.jetsnack.ui.home.cart.Cart
75	74	import com.example.jetsnack.ui.home.search.Search
76	75	import com.example.jetsnack.ui.theme.JetsnackTheme
77	76	import dev.chrisbanes.accompanist.insets.navigationBarsPadding
78		- import kotlinx.coroutines.launch
79	77
80	78	@Composable
81	79	fun Home(onSnackSelected: (Long) -> Unit) {
@@ -189,13 +187,10 @@ private fun JetsnackBottomNavLayout(
189	187	Animatable(if (i == selectedIndex) 1f else 0f)
190	188	}
191	189	}
192		- val scope = rememberCoroutineScope()
193	190	selectionFractions.forEachIndexed { index, selectionFraction ->
194	191	val target = if (index == selectedIndex) 1f else 0f
195		- if (selectionFraction.targetValue != target) {
196		- scope.launch {
197		- selectionFraction.animateTo(target, animSpec)
198		- }
	192	+ LaunchedEffect(target, animSpec) {
	193	+ selectionFraction.animateTo(target, animSpec)
199	194	}
200	195	}
201	196

0 commit comments

Comments

0 (0)