Commit 1bc255b
committed
Directly access class methods in introspection (fixes bpython#966)
inspect.signature is unable to process classmethod instances. So we
directly access the member via its __get__.1 parent 1332d18 commit 1bc255b
2 files changed
Lines changed: 3 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -358,6 +358,9 @@ def getattr_safe(obj: Any, name: str) -> Any: | |||
| 358 | 358 | # Slots are a MemberDescriptorType | |
| 359 | 359 | if isinstance(result, MemberDescriptorType): | |
| 360 | 360 | result = getattr(obj, name) | |
| 361 | + # classmethods are safe to access (see #966) | ||
| 362 | + if isinstance(result, classmethod): | ||
| 363 | + result = result.__get__(obj, obj) | ||
| 361 | 364 | return result | |
| 362 | 365 | ||
| 363 | 366 | ||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -180,7 +180,6 @@ def fun_annotations(number: int, lst: List[int] = []) -> List[int]: | |||
| 180 | 180 | self.assertEqual(props.argspec.args, ["number", "lst"]) | |
| 181 | 181 | self.assertEqual(props.argspec.defaults[0], []) | |
| 182 | 182 | ||
| 183 | - @unittest.expectedFailure | ||
| 184 | 183 | def test_issue_966_class_method(self): | |
| 185 | 184 | class Issue966(Sequence): | |
| 186 | 185 | @classmethod | |
0 commit comments