fix: align FDv2 goodbye event with spec (reason-only) - #422
Merged
keelerm84 merged 1 commit intoApr 30, 2026
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
The FDv2 goodbye event is specified to carry only a `reason` field, but the `Goodbye` dataclass declared `silent` and `catastrophe` and `from_dict` raised `ValueError` if any of the three were missing. This meant a spec-compliant payload would fail to parse. Drop `silent` and `catastrophe` from the dataclass and require only `reason` when deserializing. Update the streaming handler to log the reason unconditionally rather than gating on `silent` / formatting with `catastrophe`. Update test fixtures accordingly.
kinyoklion
approved these changes
Apr 30, 2026
keelerm84
pushed a commit
that referenced
this pull request
Jun 8, 2026
🤖 I have created a release *beep* *boop* --- ## [9.16.0](9.15.1...9.16.0) (2026-06-08) ### Features * Drop persistent-store cache after FDv2 in-memory store init ([#426](#426)) ([563b87a](563b87a)) ### Bug Fixes * align FDv2 goodbye event with spec (reason-only) ([#422](#422)) ([84b442d](84b442d)) * honor server-directed FDv1 Fallback Directive in initializer phase ([#423](#423)) ([7c49bc0](7c49bc0)) * Keep booleans and numbers distinct in the in operator ([#433](#433)) ([da595ab](da595ab)) * Replace Python 2-style ABC patterns with Python 3 equivalents ([22b8fe5](22b8fe5)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
Note
Low Risk
Low risk: change is limited to FDv2 Goodbye event serialization/parsing and corresponding log/test updates, with no new behavior beyond accepting spec-compliant payloads and adjusting log level.
Overview
Aligns the FDv2 Goodbye event with the spec by removing the silent and catastrophe fields from the Goodbye dataclass and its to_dict/from_dict methods, so parsing no longer fails on reason-only payloads.
Updates the streaming SSE consumer to treat GOODBYE as a normal protocol signal (logs info with the reason only) and adjusts datasourcev2 polling/streaming tests to construct Goodbye with just reason.
Reviewed by Cursor Bugbot for commit c1eb5cc. Bugbot is set up for automated code reviews on this repo. Configure here.