[asr->python] add complex visitors - #2581
Draft
khushi-411 wants to merge 3 commits into
Draft
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
@khushi-411 Can you add tests for this? |
Sorry, something went wrong.
ubaidsk
reviewed
Mar 7, 2024
Comment thread
src/libasr/codegen/asr_to_python.cpp
Outdated
ubaidsk
reviewed
Mar 7, 2024
Comment thread
src/libasr/codegen/asr_to_python.cpp
Outdated
ubaidsk
reviewed
Mar 7, 2024
Comment thread
src/libasr/codegen/asr_to_python.cpp
Outdated
Copy link
Copy Markdown
Collaborator
|
I would suggest focusing on one particular support in this PR. For example, either complex visitors or string visitors. And then add good tests for it. We can support the other visitors (for example string visitors) in a separate PR. |
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
Good. Now we need to add tests that test each of the implemented visitor. |
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
+1 |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.