gh-145376: Fix refleak & pointer type bug in uncommon code paths in P… · ljfp/cpython@6aa8dff · GitHub

1. ljfp
2. cpython

Repository navigation

• Code
• Pull requests
• Actions
• Projects
• Security and quality
• Insights

Commit 6aa8dff

Browse filesBrowse the repository at this point in the historyBrowse files

eendebakpt

authored and

ljfp

committed

pythongh-145376: Fix refleak & pointer type bug in uncommon code paths in Parser/ (pythonGH-145684)

1 parent 440480d commit 6aa8dff
Copy full SHA for 6aa8dff

1 file changed

+2-3Lines changed: 2 additions & 3 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• Parser
  • pegen.c

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎Parser/pegen.c‎

Copy file name to clipboardExpand all lines: Parser/pegen.c

+2-3Lines changed: 2 additions & 3 deletions

Original file line number	Diff line number	Diff line change
@@ -924,7 +924,6 @@ _PyPegen_set_syntax_error_metadata(Parser *p) {
924	924	the_source // N gives ownership to metadata
925	925	);
926	926	if (!metadata) {
927		- Py_DECREF(the_source);
928	927	PyErr_Clear();
929	928	return;
930	929	}
@@ -1026,8 +1025,8 @@ _PyPegen_run_parser_from_file_pointer(FILE *fp, int start_rule, PyObject *filena
1026	1025
1027	1026	if (tok->fp_interactive && tok->interactive_src_start && result && interactive_src != NULL) {
1028	1027	*interactive_src = PyUnicode_FromString(tok->interactive_src_start);
1029		- if (!interactive_src || _PyArena_AddPyObject(arena, *interactive_src) < 0) {
1030		- Py_XDECREF(interactive_src);
	1028	+ if (!*interactive_src || _PyArena_AddPyObject(arena, *interactive_src) < 0) {
	1029	+ Py_XDECREF(*interactive_src);
1031	1030	result = NULL;
1032	1031	goto error;
1033	1032	}

0 commit comments

Comments

0 (0)